731393 - nsDeviceContext.cpp:764:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

{
nsDeviceContext.cpp: In member function ‘bool nsDeviceContext::SetPixelScale(float)’:
nsDeviceContext.cpp:764:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}

Code in question:
> 761     PRInt32 oldAppUnitsPerDevPixel = mAppUnitsPerDevPixel;
> 762     mPixelScale = aScale;
> 763     UpdateScaledAppUnits();
> 764     return oldAppUnitsPerDevPixel != mAppUnitsPerDevPixel;

mAppUnitsPerDevPixel used to be a signed int, but it was changed a few months back to be unsigned (in bug 678222).

oldAppUnitsPerDevPixel is just a temporary cached copy of mAppUnitsPerDevPixel, and its type should clearly match.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

For reference, here's the change that made mAppUnitsPerDevPixel unsigned:
 http://hg.mozilla.org/mozilla-central/diff/8a2432d7f8f3/gfx/src/nsDeviceContext.h

Comment 3

[Joe Drew (not getting mail)]

Heck, let's give it a try.

Comment 4

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 601390
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=1a8be8b85af3
Try run started, revision 1a8be8b85af3. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=1a8be8b85af3

Comment 5

[Mozilla RelEng Bot]

Try run for 1a8be8b85af3 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1a8be8b85af3
Results (out of 169 total builds):
    exception: 5
    success: 134
    warnings: 30
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-1a8be8b85af3

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/31af9742004c

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/31af9742004c