731466 - Remove the X-Confirm-Delete header for sync2.0

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

Remove the X-Confirm-Delete header for Sync2.0.

Comment 1

[Toby Elliott [:telliott]]

Are we replacing this with anything, or just accepting delete requests and not worrying about human error?

Comment 2

[Gregory Szorc [:gps]]

What human error? Are we expecting people to type raw HTTP requests into a terminal? If a client is buggy and is stupid enough to issue a delete-the-world request, they deserve what they get.

Comment 3

[Ryan Kelly [:rfkelly]]

Also, this request will no longer delete their user profile data.  In Sync2.0 it's exactly equivalent to issuing a DELETE against each collection individually, on operation which does not currently require a confirmation header.

Comment 4

[Toby Elliott [:telliott]]

Yeah, concern is about buggy code, not humans typing. I'm fine not supporting it, as long as we've consciously thought about it.

Comment 5

[Ryan Kelly [:rfkelly]]

Attachment: patch removing X-Confirm-Delete

and here is le patch

Comment 6

[Ryan Kelly [:rfkelly]]

https://github.com/mozilla-services/server-syncstorage/commit/b9435b6461c757cc42e05af627330502f90a89f4

Comment 7

[James Bonacci [:jbonacci]]

Should be covered by functional tests.
QA to verify and close.

Comment 8

[James Bonacci [:jbonacci]]

Code verified and passed functional tests of Sync 2.0 and AITC 1.0 for a 4/23/2012 deploy to qa1.

Comment 9

[James Bonacci [:jbonacci]]

Also confirmed here: http://docs.services.mozilla.com/storage/apis-2.0.html