731526 - add an email event for product and/or component notifications

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[:glob ✱]

when configuring which email you'd like to receive on the email preferences page, there should be a row which allows you to filter when a bug's product or component changes.

currently when a bug's product or component is changed, this is caught by the "any field not mentioned above changes" row, which isn't obvious.

Comment 1

[:glob ✱]

the code to implement this change is trivial, however the migration code isn't.

when this preference is added, we should perform a one-time duplication of anyone with EVT_OTHER enabled to watch EVT_COMPONENT, however i can't see anything obvious to key off to determine if we've already performed this migration as adding the new EVT_ doesn't touch the database.

one idea i have is adding a simple meta(name,value) table, and insert a row here with a name of 'bug_731526' and a value of '1' when the migration has happened, but this feels like unwieldy.

anyone have any guidance here?

Comment 2

[Olav Vitters]

Has been done before, see _initialize_dependency_tree_changes_email_pref in Bugzilla/Install/DB.pm.

Basically: check if at least one user has that setting. If not: copy from EVT_OTHER to the new EVT_.

Comment 3

[:glob ✱]

(In reply to Olav Vitters from comment #2)
> Has been done before, see _initialize_dependency_tree_changes_email_pref in
> Bugzilla/Install/DB.pm.

ah, thanks, i missed that method.

> Basically: check if at least one user has that setting. If not: copy from
> EVT_OTHER to the new EVT_.

i wasn't a fan of doing it that way because just because no one has that setting, it doesn't necessarily mean that it's the first time this code was run.  however, as the precedent has already been set, i'll do that :)

Comment 4

[:glob ✱]

Attachment: patch v1

Comment 5

[Max Kanat-Alexander]

Comment on attachment 602290 [details] [diff] [review]
patch v1

Review of attachment 602290 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/Install/DB.pm
@@ +388,4 @@
>                "WHERE initialqacontact = 0");
>  
>      _migrate_email_prefs_to_new_table();
> +    _initialize_new_email_prefs();

This actually should be moved somewhere; probably into Bugzilla::Install.

Comment 6

[Frédéric Buclin]

Comment on attachment 602290 [details] [diff] [review]
patch v1

I wanted this for a long time. :) r=LpSolit

Comment 7

[Frédéric Buclin]

(In reply to Max Kanat-Alexander from comment #5)
> This actually should be moved somewhere; probably into Bugzilla::Install.

Maybe, but the subroutine already existed for a long time, so it's fine if this move is not done as part of this bug.

Comment 8

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Constants.pm
modified Bugzilla/User.pm
modified Bugzilla/Install/DB.pm
modified template/en/default/account/prefs/email.html.tmpl                                                                          
Committed revision 8159.

Comment 9

[Frédéric Buclin]

Added to relnotes for 4.4.