eliminate duplicate headers in layout/

RESOLVED FIXED in mozilla13

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Running:

for f in $(find layout -name '*.cpp'); do grep -B1 '#include' <(echo $f && grep '#include' $f | sort | uniq -d); done

indicates a number of duplicate #includes.  Some are necessary (atom lists and the like), but many are not.  The duplicates should be removed.
(Assignee)

Comment 1

7 years ago
Created attachment 601616 [details] [diff] [review]
patch
Attachment #601616 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #601616 - Flags: review? → review?(smontagu)
Comment on attachment 601616 [details] [diff] [review]
patch

Review of attachment 601616 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #601616 - Flags: review?(smontagu) → review+
(Assignee)

Comment 3

7 years ago
Created attachment 601946 [details] [diff] [review]
patch

Updating commit message to indicate rs instead of r.  Carrying over r+.
Attachment #601616 - Attachment is obsolete: true
Attachment #601946 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5789df0e14d1
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.