Closed Bug 731615 Opened 12 years ago Closed 12 years ago

eliminate duplicate headers in layout/

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file, 1 obsolete file)

patch
29.66 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
Running:

for f in $(find layout -name '*.cpp'); do grep -B1 '#include' <(echo $f && grep '#include' $f | sort | uniq -d); done

indicates a number of duplicate #includes.  Some are necessary (atom lists and the like), but many are not.  The duplicates should be removed.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #601616 -
        Flags: review?

    
  

        Attachment #601616 -
        Flags: review? → review?(smontagu)

    
    

    
  
Comment on attachment 601616 [details] [diff] [review]
patch

Review of attachment 601616 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

        Attachment #601616 -
        Flags: review?(smontagu) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
Updating commit message to indicate rs instead of r.  Carrying over r+.

        Attachment #601616 -
        Attachment is obsolete: true

        Attachment #601946 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5789df0e14d1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13

          You need to log in
          before you can comment on or make changes to this bug.