Closed
Bug 731615
Opened 13 years ago
Closed 13 years ago
eliminate duplicate headers in layout/
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file, 1 obsolete file)
|
29.66 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Running:
for f in $(find layout -name '*.cpp'); do grep -B1 '#include' <(echo $f && grep '#include' $f | sort | uniq -d); done
indicates a number of duplicate #includes. Some are necessary (atom lists and the like), but many are not. The duplicates should be removed.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #601616 -
Flags: review?
|
|
Assignee | |
Updated•13 years ago
|
Attachment #601616 -
Flags: review? → review?(smontagu)
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 601616 [details] [diff] [review]
patch
Review of attachment 601616 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me
Attachment #601616 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Updating commit message to indicate rs instead of r. Carrying over r+.
Attachment #601616 -
Attachment is obsolete: true
Attachment #601946 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•