731706 - Intermittent REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/counters/t1204-reset-02-c-o-test.html | image comparison (==)

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Matt Brubeck (:mbrubeck)]

The test image reads "1-2-3-3.1-4-" while the reference image reads "1-1.1-2-3-4-".

https://tbpl.mozilla.org/php/getParsedLog.php?id=9715430&tree=Firefox
Rev3 WINNT 5.1 mozilla-central debug test reftest on 2012-02-29 03:43:21 PST for push cb01e23f83cf

REFTEST TEST-START | file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/counters/t1204-reset-02-c-o-test.html | 3751 / 7406 (50%)
++DOMWINDOW == 91 (070177C0) [serial = 10178] [outer = 051EF480]
WARNING: No script language registered for this mime-type: file e:/builds/moz2_slave/m-cen-w32-dbg/build/dom/base/nsDOMScriptObjectFactory.cpp, line 159
WARNING: The script-type is unknown: file e:/builds/moz2_slave/m-cen-w32-dbg/build/content/base/src/nsDocument.cpp, line 3120
REFTEST TEST-START | file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/counters/t1204-reset-02-c-o-reference.html | 3751 / 7406 (50%)
++DOMWINDOW == 92 (126ED120) [serial = 10179] [outer = 051EF480]
WARNING: No script language registered for this mime-type: file e:/builds/moz2_slave/m-cen-w32-dbg/build/dom/base/nsDOMScriptObjectFactory.cpp, line 159
WARNING: The script-type is unknown: file e:/builds/moz2_slave/m-cen-w32-dbg/build/content/base/src/nsDocument.cpp, line 3120
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/counters/t1204-reset-02-c-o-test.html | image comparison (==)

REFTEST number of differing pixels: 117 max difference: 255
REFTEST INFO | Saved log: START file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/counters/t1204-reset-02-c-o-test.html
REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
REFTEST INFO | Saved log: Initializing canvas snapshot
REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
REFTEST INFO | Saved log: [CONTENT] RecordResult fired
REFTEST INFO | Saved log: RecordResult fired
REFTEST INFO | Saved log: START file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/counters/t1204-reset-02-c-o-reference.html
REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
REFTEST INFO | Saved log: Initializing canvas snapshot
REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
REFTEST INFO | Saved log: [CONTENT] RecordResult fired
REFTEST INFO | Saved log: RecordResult fired
REFTEST INFO | Loading a blank page
++DOMWINDOW == 93 (0A7D8D20) [serial = 10180] [outer = 051EF480]
REFTEST TEST-START | file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/counters/t1204-root-e-test.html | 3752 / 7406 (50%)

Comment 1

[Ed Morley [:emorley]]

Mass marking whiteboard:[orange] bugs WFM (to clean up TBPL bug suggestions) that:
* Haven't changed in > 6months
* Whose whiteboard contains none of the strings: {disabled,marked,random,fuzzy,todo,fails,failing,annotated,leave open,time-bomb}
* Passed a (quick) manual inspection of bug summary/whiteboard to ensure they weren't a false positive.

I've also gone through and searched for cases where the whiteboard wasn't labelled correctly after test disabling, by using attachment description & basic comment searches. However if the test for which this bug was about has in fact been disabled/annotated/..., please accept my apologies & reopen/mark the whiteboard appropriately so this doesn't get re-closed in the future (and please ping me via IRC or email so I can try to tweak the saved searches to avoid more edge cases).

Sorry for the spam! Filter on: #FFA500

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: patch

As discussed on IRC, this test should be using reftest-wait

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 675907 [details] [diff] [review]
patch

># HG changeset patch
># User Nathan Froyd <[e-mail]>
>
>fix layout/reftests/counters/t1204-reset-02-c-o-test.html intermittent orange by using MozReftestInvalidate

As in bug 778695, mention reftest-wait in commit message (and feel to drop the test's path from the commit message if you like).

Also:
>   function run() {
> 	document.getElementById("one").setAttribute("class", "reset");
>     document.getElementById("two").removeAttribute("class");
>+	document.documentElement.removeAttribute('class');
>   }

Might as well fix up the indentation on the second line there, while you're touching this.

r=me with that.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ee19554cf49