731726 - Moving the parentNode of a focused DOM node does not remove the node's focus ring

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Attachment: testcase

In the attached testcase:

1) Focus the first button using the keyboard
2) Press enter
3) Press TAB again and see that we now have two buttons with a focus ring

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Simple patch with a test. Not sure that's the way to go, looking forward to your feedback!

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Passed try: https://tbpl.mozilla.org/?tree=Try&rev=47f194251930

Comment 4

[Neil Deakin]

Comment on attachment 601723 [details] [diff] [review]
patch v2

This is ok, but a reftest would have been a simpler way of testing this.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v3 (with reftest)

(In reply to Neil Deakin from comment #4)
> This is ok, but a reftest would have been a simpler way of testing this.

Never wrote one, it was about time!

Comment 6

[Neil Deakin]

Comment on attachment 602420 [details] [diff] [review]
patch v3 (with reftest)

The line in reftest.list should be annotated with 'needs-focus' as the test depends on the window being focused.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/62ebb9b5be8c

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/62ebb9b5be8c