Moving the parentNode of a focused DOM node does not remove the node's focus ring

RESOLVED FIXED in mozilla13

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 601703 [details]
testcase

In the attached testcase:

1) Focus the first button using the keyboard
2) Press enter
3) Press TAB again and see that we now have two buttons with a focus ring
(Assignee)

Comment 1

6 years ago
Created attachment 601713 [details] [diff] [review]
patch v1

Simple patch with a test. Not sure that's the way to go, looking forward to your feedback!
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #601713 - Flags: review?(enndeakin)
(Assignee)

Updated

6 years ago
Blocks: 729878
(Assignee)

Comment 2

6 years ago
Created attachment 601723 [details] [diff] [review]
patch v2
Attachment #601713 - Attachment is obsolete: true
Attachment #601723 - Flags: review?(enndeakin)
Attachment #601713 - Flags: review?(enndeakin)
(Assignee)

Comment 3

6 years ago
Passed try: https://tbpl.mozilla.org/?tree=Try&rev=47f194251930

Comment 4

6 years ago
Comment on attachment 601723 [details] [diff] [review]
patch v2

This is ok, but a reftest would have been a simpler way of testing this.
Attachment #601723 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 602420 [details] [diff] [review]
patch v3 (with reftest)

(In reply to Neil Deakin from comment #4)
> This is ok, but a reftest would have been a simpler way of testing this.

Never wrote one, it was about time!
Attachment #601723 - Attachment is obsolete: true
Attachment #602420 - Flags: review?(enndeakin)

Comment 6

6 years ago
Comment on attachment 602420 [details] [diff] [review]
patch v3 (with reftest)

The line in reftest.list should be annotated with 'needs-focus' as the test depends on the window being focused.
Attachment #602420 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/fx-team/rev/62ebb9b5be8c
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/62ebb9b5be8c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Whiteboard: [fixed-in-fx-team]
Component: DOM: Other → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.