731776 - let orphaned users re-register after transaction bug in browser ID

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Kumar McMillan [:kumar]]

bug 731639 is creating orphaned users (that is without matching auth.User entries). Currently they cannot login with their primary browser ID login. If we delete their user profile records after pushing our bug fix then they should be able to log in and re-register.

mysql> select u.id, p.id from users p left join auth_user u on u.id=p.user_id where  u.id is null and p.created > '2012-02-28';

+------+---------+
| id   | id      |
+------+---------+
| NULL | 6115614 | 
| NULL | 6115903 | 
| NULL | 6116906 | 
| NULL | 6116960 | 
| NULL | 6117077 | 
| NULL | 6117324 | 
| NULL | 6117455 | 
| NULL | 6117472 | 
| NULL | 6117808 | 
| NULL | 6117878 | 
| NULL | 6117886 | 
| NULL | 6117936 | 
+------+---------+
12 rows in set (3.35 sec)

Comment 1

[Kumar McMillan [:kumar]]

The script just ran in production: https://github.com/mozilla/zamboni/commit/90dae5b1d650bcbaf7d1d9b42e05f9732d02ef72

these profiles were deleted:

+------+---------+
| id   | id      |
+------+---------+
| NULL | 6115614 |
| NULL | 6115903 |
| NULL | 6116906 |
| NULL | 6116960 |
| NULL | 6117077 |
| NULL | 6117324 |
| NULL | 6117455 |
| NULL | 6117472 |
| NULL | 6117808 |
| NULL | 6117878 |
| NULL | 6117886 |
| NULL | 6117936 |
| NULL | 6118340 |
| NULL | 6118474 |
| NULL | 6118515 |
| NULL | 6118755 |
| NULL | 6118847 |
| NULL | 6119098 |
| NULL | 6119118 |
| NULL | 6119606 |
+------+---------+

Comment 2

[Kumar McMillan [:kumar]]

aaaaand, looks like the fixit script only fixed 12 out of the 20 affected users. As for the remaining 8, they still had auth_user records hanging around. Here they are:

mysql> select u.id, p.id from auth_user u left join users p on p.user_id=u.id where p.id is null and u.date_joined > '2012-02-28 00:00:00';
+---------+------+
| id      | id   |
+---------+------+
| 6115903 | NULL | 
| 6116960 | NULL | 
| 6117808 | NULL | 
| 6117936 | NULL | 
| 6118340 | NULL | 
| 6118474 | NULL | 
| 6118515 | NULL | 
| 6118755 | NULL | 
+---------+------+
8 rows in set (1.04 sec)

A new fixit script is coming up to clean out auth_user

Comment 3

[Kumar McMillan [:kumar]]

The original issue in this bug was resolved with the DB migration. As for the duplicate username error we still see in prod, that has a patch in bug 731639