If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Rename mfbt/StdInt.h to mfbt/StandardInteger.h to avoid MSVC including mfbt/StdInt.h for <stdint.h>

RESOLVED FIXED in mozilla13

Status

()

Core
MFBT
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

unspecified
mozilla13
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
This is necessary in order to get stdint types from mfbt cpp files.

Patch in a moment.
(Assignee)

Comment 1

6 years ago
Created attachment 601769 [details] [diff] [review]
Part 1: Rename mfbt/StdInt.h to mfbt/StandardInteger.h, to placate MSVC.
Attachment #601769 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 2

6 years ago
Created attachment 601770 [details] [diff] [review]
Part 2: s/StdInt.h/StandardInteger.h.
Attachment #601770 - Flags: review?(jwalden+bmo)
(Assignee)

Updated

6 years ago
Blocks: 729940
(Assignee)

Updated

6 years ago
Assignee: nobody → justin.lebar+bug
Comment on attachment 601769 [details] [diff] [review]
Part 1: Rename mfbt/StdInt.h to mfbt/StandardInteger.h, to placate MSVC.

Review of attachment 601769 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/StdInt.h
@@ +62,5 @@
>   *      <stdint.h>, #include our custom <stdint.h> reimplementation.
>   *   3. Otherwise, #include the standard <stdint.h> provided by the compiler.
> + *
> + * Note that we can't call this file "stdint.h" or something case-insensitively
> + * equal to "stdint.h" because then MSVC (and possibly other compilers on

s/possibly // since this has happened in the past
Attachment #601769 - Flags: review?(jwalden+bmo) → review+
Attachment #601770 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 4

6 years ago
This had a green try run at https://tbpl.mozilla.org/?tree=Try&rev=b8ebf3c4ca59

https://hg.mozilla.org/integration/mozilla-inbound/rev/a771e4924188
https://hg.mozilla.org/mozilla-central/rev/a771e4924188
https://hg.mozilla.org/mozilla-central/rev/4daba22659e3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.