Closed Bug 731789 Opened 8 years ago Closed 8 years ago

Rename mfbt/StdInt.h to mfbt/StandardInteger.h to avoid MSVC including mfbt/StdInt.h for <stdint.h>

Categories

(Core :: MFBT, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(2 files)

This is necessary in order to get stdint types from mfbt cpp files.

Patch in a moment.
Attachment #601770 - Flags: review?(jwalden+bmo)
Blocks: 729940
Assignee: nobody → justin.lebar+bug
Comment on attachment 601769 [details] [diff] [review]
Part 1: Rename mfbt/StdInt.h to mfbt/StandardInteger.h, to placate MSVC.

Review of attachment 601769 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/StdInt.h
@@ +62,5 @@
>   *      <stdint.h>, #include our custom <stdint.h> reimplementation.
>   *   3. Otherwise, #include the standard <stdint.h> provided by the compiler.
> + *
> + * Note that we can't call this file "stdint.h" or something case-insensitively
> + * equal to "stdint.h" because then MSVC (and possibly other compilers on

s/possibly // since this has happened in the past
Attachment #601769 - Flags: review?(jwalden+bmo) → review+
Attachment #601770 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/a771e4924188
https://hg.mozilla.org/mozilla-central/rev/4daba22659e3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.