731857 - appdir page won't render on staging environment

Status: VERIFIED FIXED

(Web Apps :: HTML, defect)

Description

[[e-mail] [:onecyrenus]]

https://stage-myapps.mozillalabs.com/apps/appdir/
https://stage-myapps.mozillalabs.com/

basically it's because getInstalledBy is not implemented

Comment 1

[[e-mail] [:onecyrenus]]

not a big deal as i imagine this is why we aren't shipping.

Comment 2

[Jason Smith [:jsmith]]

Comparing to https://apps.mozillalabs.com/appdir/, I am seeing the appdir render fine on both Firefox 11 Beta and Chrome. If I recall, I thought the new mozApps API was deployed to apps.mozillalabs.com/appdir, although I could be mistaken.

David - Could you double check what build of appdir you are using and specify it here (e.g. what github branch, how its built, etc).

Ian - Any ideas on why https://stage-myapps.mozillalabs.com/apps/appdir/ != https://apps.mozillalabs.com/appdir/?

Comment 3

[Ian Bicking (:ianbicking)]

I think the problem here is that the apps submodule reference (in openwebapps/site/tools/apps.mozillalabs.com) has not been updated, so it's pointing to an old version of apps/appdir/ - I've updated that submodule and I think with a rebuild it will work.

Comment 4

[Ian Bicking (:ianbicking)]

Not sure who would deploy the fix, but unassigning myself as I wasn't planning to (maybe David can confirm details with me so I can do later deployments).

Comment 5

[[e-mail] [:onecyrenus]]

prob needs to be discussed who would deploy to the staging environment going forward.

Comment 6

[[e-mail] [:onecyrenus]]

pushed a new build to the staging server today, so it has the latest bits.

Comment 7

[Ian Bicking (:ianbicking)]

This appears fixed on staging

Comment 8

[Jason Smith [:jsmith]]

Verified yesterday in staging validation.