Closed Bug 731898 Opened 8 years ago Closed 8 years ago

Remove jsrefcount

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: dmandelin, Assigned: dmandelin)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Attached patch PatchSplinter Review
I think Chris added this as a type to use for reference counts that need to be updated atomically. Fair enough, but now that I'm on a warpath, I only want to keep extra typedefs that serve a compelling purpose. It looks like 'unsigned' will do fine for all the current use cases.
Attachment #601847 - Flags: review?(luke)
Comment on attachment 601847 [details] [diff] [review]
Patch

Need to fix alignment on gcAtomBytes and depth.
Attachment #601847 - Flags: review?(luke) → review+
backed out for Android bustage
Sorry, didn't see the Android failure on try among all the noise. Just pushed a new patch, which appears to have passed try on Android as evidenced by a build dir full of stuff, although oddly, tbpl doesn't show it.

http://hg.mozilla.org/integration/mozilla-inbound/rev/9613e21afa34
https://hg.mozilla.org/mozilla-central/rev/9613e21afa34
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.