731898 - Remove jsrefcount

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

Attachment: Patch

I think Chris added this as a type to use for reference counts that need to be updated atomically. Fair enough, but now that I'm on a warpath, I only want to keep extra typedefs that serve a compelling purpose. It looks like 'unsigned' will do fine for all the current use cases.

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 601847 [details] [diff] [review]
Patch

Need to fix alignment on gcAtomBytes and depth.

Comment 2

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/51bff179fa81

Comment 3

[Marco Bonardo [:mak]]

backed out for Android bustage

Comment 4

[David Mandelin [:dmandelin]]

Sorry, didn't see the Android failure on try among all the noise. Just pushed a new patch, which appears to have passed try on Android as evidenced by a build dir full of stuff, although oddly, tbpl doesn't show it.

http://hg.mozilla.org/integration/mozilla-inbound/rev/9613e21afa34

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/9613e21afa34

Comment 6

[Jeff Walden [:Waldo]]

Noted in release notes:

https://developer.mozilla.org/en/SpiderMonkey/1.8.8