731904 - get rid nsCoreUtils::IsCorrectFrameType

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Nowdays nsCoreUtils::IsCorrectFrameType is aFrame->GetType() == aAtom. We don't need util method for this.

Comment 1

[alexander :surkov (:asurkov)]

(In reply to alexander :surkov from comment #0)
> Nowdays nsCoreUtils::IsCorrectFrameType is aFrame->GetType() == aAtom.

fyi, bug 190735 changed that

Comment 2

[Mark Capella [:capella]]

Attachment: Patch (v1)

Attached changes built clean locally, run clean mochitest-a11y test, mochitest-plain run clean with some timeouts ...

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 602729 [details] [diff] [review]
Patch (v1)

Review of attachment 602729 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessible.cpp
@@ +969,5 @@
>      *aBoundingFrame = ancestorFrame;
>      // If any other frame type, we only need to deal with the primary frame
>      // Otherwise, there may be more frames attached to the same content node
> +    if (!(ancestorFrame->GetType() == nsGkAtoms::inlineFrame) &&
> +        !(ancestorFrame->GetType() == nsGkAtoms::textFrame))

Make this use != instead

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 602729 [details] [diff] [review]
Patch (v1)

r=me with Ms2ger's comment addressed (I'll fix it before landing)

Comment 5

[Mark Capella [:capella]]

Attachment: Patch (v2)

Better code patch attached ... build running ...

Comment 6

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/158587a6b17e

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/158587a6b17e