Closed Bug 731904 Opened 8 years ago Closed 8 years ago

get rid nsCoreUtils::IsCorrectFrameType

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: surkov, Assigned: capella)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 file, 1 obsolete file)

Nowdays nsCoreUtils::IsCorrectFrameType is aFrame->GetType() == aAtom. We don't need util method for this.
(In reply to alexander :surkov from comment #0)
> Nowdays nsCoreUtils::IsCorrectFrameType is aFrame->GetType() == aAtom.

fyi, bug 190735 changed that
Attached patch Patch (v1) (obsolete) — Splinter Review
Attached changes built clean locally, run clean mochitest-a11y test, mochitest-plain run clean with some timeouts ...
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Comment on attachment 602729 [details] [diff] [review]
Patch (v1)

Review of attachment 602729 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessible.cpp
@@ +969,5 @@
>      *aBoundingFrame = ancestorFrame;
>      // If any other frame type, we only need to deal with the primary frame
>      // Otherwise, there may be more frames attached to the same content node
> +    if (!(ancestorFrame->GetType() == nsGkAtoms::inlineFrame) &&
> +        !(ancestorFrame->GetType() == nsGkAtoms::textFrame))

Make this use != instead
Comment on attachment 602729 [details] [diff] [review]
Patch (v1)

r=me with Ms2ger's comment addressed (I'll fix it before landing)
Attachment #602729 - Flags: review+
Attached patch Patch (v2)Splinter Review
Better code patch attached ... build running ...
Attachment #602729 - Attachment is obsolete: true
Attachment #602732 - Flags: review?(surkov.alexander)
Attachment #602732 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/158587a6b17e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Attachment #602732 - Flags: feedback+
You need to log in before you can comment on or make changes to this bug.