Optimizations are disabled in NSPR when using --enable-optimize in mozconfig.

RESOLVED FIXED in mozilla13

Status

defect
RESOLVED FIXED
7 years ago
Last year

People

(Reporter: tete009+bugzilla, Assigned: espindola)

Tracking

({regression})

Trunk
mozilla13
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

7 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120215223356

Steps to reproduce:

I specified compiler optimization options using --enable-optimize option in my mozconfig file.


Actual results:

In NSPR module, the above compiler optimization options were ignored. Instead, -Od compiler option was used.


Expected results:

Should have applied the compiler optimization options, specified in --enable-optimize option of a mozconfig file, to NSPR module.
Component: Untriaged → Build Config
QA Contact: untriaged → build.config
this is regression of bug 669953. if you add --enable-optimize=-O2, MOZ_OPTIMZIE becomes 2...
Blocks: 669953
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Product: Firefox → Core
QA Contact: build.config → build-config
Hardware: x86_64 → All
Assignee: nobody → respindola
With MOZ_OPTIMIZE=1 we pass --enable-optimize as we did before.

With MOZ_OPTIMIZE=2 we know that there is a --enable-optimize=foo in the command line, we don't need to add anything.

If MOZ_OPTIMIZE is empty, we pass --disable-optimize
Attachment #602006 - Flags: review?(khuey)
Keywords: regression
https://hg.mozilla.org/mozilla-central/rev/bfdf82d12fa0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13

Comment 5

7 years ago
And another thing, if I use 

export MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
mk_add_options MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"

in the mozconfig

it also can't be transfered to nsprpub module

is this an expected behavior?
(In reply to xunxun from comment #5)
> And another thing, if I use 
> 
> export MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
> mk_add_options MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
> 
> in the mozconfig
> 
> it also can't be transfered to nsprpub module
> 
> is this an expected behavior?

please file a new bug.  NSPR doesn't use MOZ_OPTIMIZE_LDFLAGS

Comment 7

7 years ago
(In reply to Makoto Kato from comment #6)
> (In reply to xunxun from comment #5)
> > And another thing, if I use 
> > 
> > export MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
> > mk_add_options MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
> > 
> > in the mozconfig
> > 
> > it also can't be transfered to nsprpub module
> > 
> > is this an expected behavior?
> 
> please file a new bug.  NSPR doesn't use MOZ_OPTIMIZE_LDFLAGS

Done.
https://bugzilla.mozilla.org/show_bug.cgi?id=736925

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.