731936 - Optimizations are disabled in NSPR when using --enable-optimize in mozconfig.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Tetsuro Kato (tete)]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120215223356

Steps to reproduce:

I specified compiler optimization options using --enable-optimize option in my mozconfig file.


Actual results:

In NSPR module, the above compiler optimization options were ignored. Instead, -Od compiler option was used.


Expected results:

Should have applied the compiler optimization options, specified in --enable-optimize option of a mozconfig file, to NSPR module.

Comment 1

[Makoto Kato [:m_kato]]

this is regression of bug 669953. if you add --enable-optimize=-O2, MOZ_OPTIMZIE becomes 2...

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: pass the correct --enable-optimize to subconfigure

With MOZ_OPTIMIZE=1 we pass --enable-optimize as we did before.

With MOZ_OPTIMIZE=2 we know that there is a --enable-optimize=foo in the command line, we don't need to add anything.

If MOZ_OPTIMIZE is empty, we pass --disable-optimize

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=bfdf82d12fa0

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/bfdf82d12fa0

Comment 5

[xunxun]

And another thing, if I use 

export MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
mk_add_options MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"

in the mozconfig

it also can't be transfered to nsprpub module

is this an expected behavior?

Comment 6

[Makoto Kato [:m_kato]]

(In reply to xunxun from comment #5)
> And another thing, if I use 
> 
> export MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
> mk_add_options MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
> 
> in the mozconfig
> 
> it also can't be transfered to nsprpub module
> 
> is this an expected behavior?

please file a new bug.  NSPR doesn't use MOZ_OPTIMIZE_LDFLAGS

Comment 7

[xunxun]

(In reply to Makoto Kato from comment #6)
> (In reply to xunxun from comment #5)
> > And another thing, if I use 
> > 
> > export MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
> > mk_add_options MOZ_OPTIMIZE_LDFLAGS="-opt:ref,icf mylib.lib"
> > 
> > in the mozconfig
> > 
> > it also can't be transfered to nsprpub module
> > 
> > is this an expected behavior?
> 
> please file a new bug.  NSPR doesn't use MOZ_OPTIMIZE_LDFLAGS

Done.
https://bugzilla.mozilla.org/show_bug.cgi?id=736925