Closed Bug 732114 Opened 9 years ago Closed 9 years ago

Untangle Bookmark specific code in AndroidBrowserRepositoryTest

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P4)

All
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla13

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

At the moment, there is Bookmark specific code in AndroidBrowserRepositoryTest (which should be moved into AndroidBrowserBookmarkRepositoryTest).  This ticket is for untangling that code.
 
Bug 722470 is a much larger untangling.
N.B., it's OK for AndroidBrowserRepositoryTest to be bookmarks-and-history specific; it (and AndroidBrowserRepository*) exist solely because bookmarks and history were very tightly coupled.

It would be nice to do away with as much needless sharing as possible, both in the tests and in the code. Ideally the only sharing should be the stuff that is shared between all "conventional" (i.e., reconciling, deleting, etc.) engines.
Blocks: 722470
Depends on: 732768
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b5406dd1fe6
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/8b5406dd1fe6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.