732183 - sut_tools/check.py incorrectly handles when checkSlaveActive fails

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Mike Taylor [:bear]]

logTD = checkSlaveActive(tegraPath)

logTD turns out can return as None and the existing check on line 127 of check.py fails causing an exception.

Comment 1

[Mike Taylor [:bear]]

Attachment: change handling of return value from check*Active() to handle None properly

Comment 2

[Mike Taylor [:bear]]

i'm testing this on foopy17 since it was tegra-198 that caused me to discover the bug

Comment 3

[hwine]

Comment on attachment 602102 [details] [diff] [review]
change handling of return value from check*Active() to handle None properly

Original defect was improper grouping of clauses, allowing logTD to be introspected even when None. Instead of making the conditionals more complex with yet another layer of parenthesis, this restructures to show more clearly logTD==None means status is INACTIVE.

approved as long as tests pass.

Comment 4

[Mike Taylor [:bear]]

committed changeset 2291:b0f38fe095c3