732230 - [nl] Port bug 731590 - Update Search Engine list for Thunderbird

Status: RESOLVED FIXED

(Mozilla Localizations :: nl / Dutch, defect)

Description

[Mark Banner (:standard8)]

The search engines list has changed in Thunderbird for en-US. See bug 731590 for the new list.

The attached patch brings nl up to date with these changes. Please review and check that it will work for you.

If you have queries or issues, please feel free to ask.

If you are happy with the patch, please set the review flag to + and comment here.

When we are happy with the patch, I will commit and push to the relevant l10n repos - please let me know if you want it committed to central, aurora and/or beta. You will need to update your sign-off when you are ready.

Comment 1

[Mark Banner (:standard8)]

Attachment: Update search engines

nl search engine update

Comment 2

[Tim Maks van den Broek [:mad_maks]]

Comment on attachment 602156 [details] [diff] [review]
Update search engines

Please commit to central/aurora/beta, thanks

Comment 3

[Ton [:Tonnes]]

1) I’m not sure why the product team has agreed to use Bing over Google and would probably not choose to do so myself, but if it needs to, so be it.
2) Shouldn’t list.txt match the engines used, and vice versa (regarding the xml files)?

Comment 4

[Tim Maks van den Broek [:mad_maks]]

(In reply to Ton from comment #3)

> 2) Shouldn’t list.txt match the engines used, and vice versa (regarding the
> xml files)?

it matches with the xml files. if the file isn't in the nl searchplugins dir it uses the en-us xml file (http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/searchplugins/). And xml files who are not in the list are ignored.

we don't have localized searchplugins for the dutch thunderbird, if we want that we have to discus that (in a separate bug). because of that if gived a review + to the patch (we follow en-US as long we don't have discus/decided to have localized searchplugins like firefox).

Comment 5

[Mark Banner (:standard8)]

(In reply to Ton from comment #3)
> 1) I’m not sure why the product team has agreed to use Bing over Google and
> would probably not choose to do so myself, but if it needs to, so be it.

This is due to business rationale & legal decisions. We believe that Bing will give results that are comparable to Google.

Comment 6

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/l10n-central/nl/rev/ef8654509f46
http://hg.mozilla.org/releases/l10n/mozilla-aurora/nl/rev/f8875e7913dc
http://hg.mozilla.org/releases/l10n/mozilla-beta/nl/rev/ac4eb5b67922

Please can you check the landing, and sign-off when appropriate. As the last beta is building in the next few hours, I'll update your sign-off on mozilla-beta if appropriate, unless you do it first, if there's any issues please let me know asap.

Thanks.