732296 - Username text field on incorrect login into Case Conductor becomes misaligned with username

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: MozTrap, defect)

Description

[Jason Smith [:jsmith]]

Attachment: Username textfield misalignment on incorrect login

Steps:

1. Go to https://caseconductor.allizom.org/users/login/
2. Put in an incorrect login

Expected:

The username text field should remain in alignment with the username text.

Actual:

The error message appears in the location of the alignment with the username, causing the username text field to shift down. I would expect that the username text field even on incorrect login, should still remain in alignment with the username.

Comment 1

[Cameron Dawson [:camd]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/26101557

Comment 2

[Cameron Dawson [:camd]]

Eric Meyer added a comment in Pivotal Tracker:   
   
this is a duplicate of https://www.pivotaltracker.com/story/show/25658815 - though this one actully has a bugzilla bug attached.

Comment 3

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
from carl's comment on other tracker issue:
Non-field errors currently look un-wireframed; they're oddly offset to the left from the form fields.

You can see a non-field error by trying to save a test run with an end date earlier than its start date. Or on any form (once I merge the master-concurrency branch), by opening up two copies of the form in two tabs and saving first one, then the other. The second save will show an "another user has edited this object in the meantime" non-field error.

Comment 4

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
using this issue, since it has a bugzilla id associated.  deleting the other.

Comment 5

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
from carl:
should be fixed on 0.8.X branch and merged into master

Comment 6

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
(master-concurrency branch is merged, so you can see this in any of the ways mentioned above. and it should still be fixed in 0.8.X and then merged into master)

Comment 7

[Cameron Dawson [:camd]]

Eric Meyer changed story state to started in Pivotal Tracker

Comment 8

[Cameron Dawson [:camd]]

Eric Meyer changed story state to delivered in Pivotal Tracker

Comment 9

[Cameron Dawson [:camd]]

Eric Meyer changed story state to delivered in Pivotal Tracker

Comment 10

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to accepted in Pivotal Tracker

Comment 11

[Matt Brandt [:mbrandt]]

Bumping to verified as [qa-] due to age of bug, shipped.

Note this shouldn't be a problem, Mozilla has moved to a brower-id based login workflow