need os.close(fd) before os.remove(tmp) on expandlibs_exec.py

RESOLVED FIXED in mozilla13

Status

RESOLVED FIXED
7 years ago
9 months ago

People

(Reporter: m_kato, Unassigned)

Tracking

unspecified
mozilla13
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
expandlibs_exec.py throws the following exception.  When removing tmp file, file still seems to open since os handle isn't closed.

Traceback (most recent call last):
  File "c:/Workspace/hg.mozilla.org/mozilla-central/config/pythonpath.py", line 52, in <module>
    main(sys.argv[1:])
  File "c:/Workspace/hg.mozilla.org/mozilla-central/config/pythonpath.py", line 44, in main
    execfile(script, frozenglobals)
  File "c:/Workspace/hg.mozilla.org/mozilla-central/config/expandlibs_exec.py", line 180, in <module>
    main()
  File "c:/Workspace/hg.mozilla.org/mozilla-central/config/expandlibs_exec.py", line 168, in main
    args.makelist()
  File "c:/Workspace/hg.mozilla.org/mozilla-central/config/expandlibs_exec.py", line 122, in makelist
    os.remove(tmp)
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\Workspace\\hg.mozilla.org\\objdir\\build\\win32\\tmpqonfcu.list'
(Reporter)

Updated

7 years ago
Attachment #602264 - Flags: review?(ted.mielczarek)
Attachment #602264 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/55a14858a2b6
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla13

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.