Closed Bug 732328 Opened 13 years ago Closed 13 years ago

need os.close(fd) before os.remove(tmp) on expandlibs_exec.py

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla13

People

(Reporter: m_kato, Unassigned)

Details

Attachments

(1 file)

expandlibs_exec.py throws the following exception. When removing tmp file, file still seems to open since os handle isn't closed. Traceback (most recent call last): File "c:/Workspace/hg.mozilla.org/mozilla-central/config/pythonpath.py", line 52, in <module> main(sys.argv[1:]) File "c:/Workspace/hg.mozilla.org/mozilla-central/config/pythonpath.py", line 44, in main execfile(script, frozenglobals) File "c:/Workspace/hg.mozilla.org/mozilla-central/config/expandlibs_exec.py", line 180, in <module> main() File "c:/Workspace/hg.mozilla.org/mozilla-central/config/expandlibs_exec.py", line 168, in main args.makelist() File "c:/Workspace/hg.mozilla.org/mozilla-central/config/expandlibs_exec.py", line 122, in makelist os.remove(tmp) WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\Workspace\\hg.mozilla.org\\objdir\\build\\win32\\tmpqonfcu.list'
Attached patch fixSplinter Review
Attachment #602264 - Flags: review?(ted.mielczarek)
Attachment #602264 - Flags: review?(ted.mielczarek) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: