Last Comment Bug 732379 - send window is roundish and lacks border at top
: send window is roundish and lacks border at top
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Windows 7
: -- minor (vote)
: Thunderbird 14.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-02 04:54 PST by Andreas Nilsson (:andreasn)
Modified: 2012-03-26 17:39 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
before and after (113.49 KB, image/png)
2012-03-02 04:54 PST, Andreas Nilsson (:andreasn)
no flags Details
Fix (1.76 KB, patch)
2012-03-03 00:02 PST, Richard Marti (:Paenglab)
bugs: ui‑review+
Details | Diff | Review
No transparent window (3.83 KB, patch)
2012-03-03 00:10 PST, Richard Marti (:Paenglab)
bugs: feedback+
Details | Diff | Review
No transparent window for AB and Compozer (7.13 KB, patch)
2012-03-07 12:44 PST, Richard Marti (:Paenglab)
no flags Details | Diff | Review
No transparent window for AB and Compozer v2 (7.93 KB, patch)
2012-03-11 05:04 PDT, Richard Marti (:Paenglab)
no flags Details | Diff | Review
toolbar comparisions (95.97 KB, image/png)
2012-03-20 11:19 PDT, Andreas Nilsson (:andreasn)
no flags Details
No transparent window for AB and Compozer v3 (8.58 KB, patch)
2012-03-20 12:55 PDT, Richard Marti (:Paenglab)
bugs: review+
bugs: ui‑review+
Details | Diff | Review

Description Andreas Nilsson (:andreasn) 2012-03-02 04:54:30 PST
Created attachment 602314 [details]
before and after

On nightly the compose window currently lacks a 1px line and is somewhat rounded (3.5px or so) at the top.
Comment 1 Jim Porter (:squib) 2012-03-02 10:54:08 PST
We should probably make the background extend up to the top of the window so that the toolbar and menubar aren't glassy (like how the main window is now).
Comment 2 Richard Marti (:Paenglab) 2012-03-03 00:02:18 PST
Created attachment 602580 [details] [diff] [review]
Fix

This patch removes the radii and gives a border.

Bwinton asked for the radii. But because to add the radii in AB was not doable with the treecols on top, the compozer was the only window with radii and it makes sense to remove them.
Comment 3 Richard Marti (:Paenglab) 2012-03-03 00:10:55 PST
Created attachment 602582 [details] [diff] [review]
No transparent window

Andreas, what do you mean to this non-transparent window as suggested by squib?

When you like it, I can do this also for the AB. This two windows are the only with this toolbars on Glass.
Comment 4 Andreas Nilsson (:andreasn) 2012-03-07 10:30:14 PST
Comment on attachment 602582 [details] [diff] [review]
No transparent window

Feedback+ from me
Comment 5 Richard Marti (:Paenglab) 2012-03-07 12:44:50 PST
Created attachment 603824 [details] [diff] [review]
No transparent window for AB and Compozer

This patch removes the Aero transparency on AB and Compozer. To look better (also wished by mconley) I added a padding of 1px at top and bottom of the toolbars.
Comment 6 Richard Marti (:Paenglab) 2012-03-11 05:04:35 PDT
Created attachment 604765 [details] [diff] [review]
No transparent window for AB and Compozer v2

I forgot the toolbox's bottom border.
Comment 7 Andreas Nilsson (:andreasn) 2012-03-20 11:19:20 PDT
Created attachment 607630 [details]
toolbar comparisions

Compared to the main window, the toolbars are bending inwards towards the bottom and I think it would look nicer with a similar flat view. Comparision with current patch at the top and color proposal at the bottom.
Comment 8 Richard Marti (:Paenglab) 2012-03-20 12:55:13 PDT
Created attachment 607672 [details] [diff] [review]
No transparent window for AB and Compozer v3

Made the gradients the same as on main window.
Comment 9 Andreas Nilsson (:andreasn) 2012-03-20 13:51:05 PDT
Comment on attachment 607672 [details] [diff] [review]
No transparent window for AB and Compozer v3

UI look good! Will review the css shortly.
Comment 10 Andreas Nilsson (:andreasn) 2012-03-26 08:32:11 PDT
Comment on attachment 607672 [details] [diff] [review]
No transparent window for AB and Compozer v3

css looks good as far as I can see.
Comment 11 Ryan VanderMeulen [:RyanVM] 2012-03-26 17:39:13 PDT
http://hg.mozilla.org/comm-central/rev/1ea6513ec1b2

Note You need to log in before you can comment on or make changes to this bug.