send window is roundish and lacks border at top

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Theme
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 14.0
All
Windows 7
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 4 obsolete attachments)

(Reporter)

Description

5 years ago
Created attachment 602314 [details]
before and after

On nightly the compose window currently lacks a 1px line and is somewhat rounded (3.5px or so) at the top.

Comment 1

5 years ago
We should probably make the background extend up to the top of the window so that the toolbar and menubar aren't glassy (like how the main window is now).
(Assignee)

Comment 2

5 years ago
Created attachment 602580 [details] [diff] [review]
Fix

This patch removes the radii and gives a border.

Bwinton asked for the radii. But because to add the radii in AB was not doable with the treecols on top, the compozer was the only window with radii and it makes sense to remove them.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #602580 - Flags: ui-review?(nisses.mail)
Attachment #602580 - Flags: review?(nisses.mail)
(Assignee)

Comment 3

5 years ago
Created attachment 602582 [details] [diff] [review]
No transparent window

Andreas, what do you mean to this non-transparent window as suggested by squib?

When you like it, I can do this also for the AB. This two windows are the only with this toolbars on Glass.
Attachment #602582 - Flags: feedback?(nisses.mail)
(Reporter)

Updated

5 years ago
Attachment #602580 - Flags: ui-review?(nisses.mail) → ui-review+
(Reporter)

Comment 4

5 years ago
Comment on attachment 602582 [details] [diff] [review]
No transparent window

Feedback+ from me
Attachment #602582 - Flags: feedback?(nisses.mail) → feedback+
(Assignee)

Comment 5

5 years ago
Created attachment 603824 [details] [diff] [review]
No transparent window for AB and Compozer

This patch removes the Aero transparency on AB and Compozer. To look better (also wished by mconley) I added a padding of 1px at top and bottom of the toolbars.
Attachment #602580 - Attachment is obsolete: true
Attachment #602582 - Attachment is obsolete: true
Attachment #603824 - Flags: ui-review?(nisses.mail)
Attachment #603824 - Flags: review?(nisses.mail)
Attachment #602580 - Flags: review?(nisses.mail)
(Assignee)

Comment 6

5 years ago
Created attachment 604765 [details] [diff] [review]
No transparent window for AB and Compozer v2

I forgot the toolbox's bottom border.
Attachment #603824 - Attachment is obsolete: true
Attachment #604765 - Flags: ui-review?(nisses.mail)
Attachment #604765 - Flags: review?(nisses.mail)
Attachment #603824 - Flags: ui-review?(nisses.mail)
Attachment #603824 - Flags: review?(nisses.mail)
(Reporter)

Comment 7

5 years ago
Created attachment 607630 [details]
toolbar comparisions

Compared to the main window, the toolbars are bending inwards towards the bottom and I think it would look nicer with a similar flat view. Comparision with current patch at the top and color proposal at the bottom.
(Assignee)

Comment 8

5 years ago
Created attachment 607672 [details] [diff] [review]
No transparent window for AB and Compozer v3

Made the gradients the same as on main window.
Attachment #604765 - Attachment is obsolete: true
Attachment #607672 - Flags: ui-review?(nisses.mail)
Attachment #607672 - Flags: review?(nisses.mail)
Attachment #604765 - Flags: ui-review?(nisses.mail)
Attachment #604765 - Flags: review?(nisses.mail)
(Reporter)

Comment 9

5 years ago
Comment on attachment 607672 [details] [diff] [review]
No transparent window for AB and Compozer v3

UI look good! Will review the css shortly.
Attachment #607672 - Flags: ui-review?(nisses.mail) → ui-review+
(Reporter)

Comment 10

5 years ago
Comment on attachment 607672 [details] [diff] [review]
No transparent window for AB and Compozer v3

css looks good as far as I can see.
Attachment #607672 - Flags: review?(nisses.mail) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/1ea6513ec1b2
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 14.0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.