73238 - search results not displaying in sidebar

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect, P1)

Description

[Tracy Walker [:tracy]]

seen on commercial builds:

windows 2001-03-23-06-mtrunk
linux 2001-03-23-05-mtrunk
mac 2001-03-23-04-trunk

-run a search from the URL bar

expected results:  sidebar opens with results in search tab

tested results: sidebar remains empty

Comment 1

[Tracy Walker [:tracy]]

note: the results do display in the browser

Comment 2

[sujay]

This should go to Search component and QA_contact = Claudius

Comment 3

[sujay]

changing to search and qa_contact.

Comment 4

[Claudius Gayle]

uh-oh. Didn't we see this smae bug just a few days ago or am i making it up (couldn't find
a dupe)

Comment 5

[Colin Blake]

fyi - this regression is present in the 0.8.1 release

Comment 6

[Paul Chen]

nav triage team:

Marking nsbeta1+, mozilla0.9 since Matt's looking at search right now.

Comment 7

[R.K.Aa.]

*** Bug 75923 has been marked as a duplicate of this bug. ***

Comment 8

[matt]

Status on this bug.
I've tried this bug on 2 machines and I get results.
I've also tried it on mozilla, netscape comm., and my debug build.
I went to Claudius' machine and it worked.
Blake says he still see this bug.

I think this might be have something to do with profiles.  This is
just a guess.  I've asked Claudius to do some more investigation.

Comment 9

[Tracy Walker [:tracy]]

the last  time on say this on the daily smoketests was 4/11

Comment 10

[matt]

vishy says "ask qa to give you a better reproducible test case."
so how about it.
thanks

Comment 11

[Andreas Becker]

This appears to be a profile issue since by default no search engine is 
selected.

1. create a new profile (don't migrate from an existing one)
2. in "My Sidebar" select the search tab
3. type in search value, e.g. "test" and click on search
   -> no results are found
4. from the menu select "Search/My Sidebar Search Tab/Advanced"
   -> you should see a list of search engines, none of those is selected though
      (shouldn't there be one selected by default for newly created profiles?)
5. now choose one, e.g. Netscape Search and perform the same search again
   -> results are found

Comment 12

[matt]

thanks for that finding.  I think i might be able to fix this bug by just 
checking in a default search engine in all.js .

Comment 13

[Viswanath Ramachandran]

Claudius - can we try to narrow this down to a more easily reproducible test 
case? thanks, Vishy

Comment 14

[matt]

Attachment: patch for search panel for checks

Comment 15

[matt]

need reviews

Comment 16

[Alec Flett]

can you switch to using the nsIPrefBranch interface? nsIPref is deprecated -
basically just QI to nsIPrefBranch, and use the methods listed there...(it's
pretty obvious which is which)

btw, can you give me cvs diff -u in the future?

Comment 17

[timeless]

tabs, don't add dumps to release code, 
after rereading, i now understand the pref stuff :)

Comment 18

[matt]

Attachment: updated patch with nsIPrefBranch change

Comment 19

[matt]

Fixed

to test claudius:
1. create a new profile (don't migrate from an existing one)
2. in "My Sidebar" select the search tab
3. type in search value, e.g. "test" and click on search
   -> no results are found
4. from the menu select "Search/My Sidebar Search Tab/Advanced"
   -> you should see a list of search engines, none of those is selected though
      (shouldn't there be one selected by default for newly created profiles?)
5. now choose one, e.g. Netscape Search and perform the same search again
   -> results are found

Comment 20

[Alec Flett]

bastard! you didn't fix those tabs.

Comment 21

[Claudius Gayle]

this bug is VERIFIED Fixed in 20010511 builds. -matt i just filed a bugscape bug for you as
an offshoot of this one.

Comment 22

[Viswanath Ramachandran]

whats the bugscape bug for?