732414 - WebSMS: Expose nsIDOMMozSmsFilter to xpcshell

Status: RESOLVED WONTFIX

(Core :: DOM: Device Interfaces, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

Currently, there is no way to create an SmsFilter in xpcshell, since XPCOM isn´t told about the class, only about the interface.

Comment 1

[Philipp von Weitershausen [:philikon]]

Yeah, that's a good one. Because it's just a DOM object, the C++ implementation doesn't have a CID/ContractID with which we can instantiate it. And implementing our own nsIDOMMozSmsFilter in JS for testing purposes doesn't work either because the interface is marked [builtinclass] -- for a good reason, because the DOM IPC implementation depends on C++ implementation internals.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

What do we need to test in xpcshell here that we can't test in the emulator?

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #2)
> What do we need to test in xpcshell here that we can't test in the emulator?

Functionally, nothing. xpcshell tests are just much quicker to run and don't depend on any UI. So if there's a low hanging fruit to *unit* test the SmsDatabaseService we're writing, I'll take it.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: WIP v1

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 602923 [details] [diff] [review]
WIP v1

Review of attachment 602923 [details] [diff] [review]:
-----------------------------------------------------------------

Seems sad to do this *only* for tests...
Can't this test be made in a mochitest?

r=me because the patch is correct but I would like to discuss the other solutions before landing this.

Comment 6

[Philipp von Weitershausen [:philikon]]

(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #5)
> Seems sad to do this *only* for tests...
> Can't this test be made in a mochitest?

Hmm, right, it can. That might indeed be better.

Comment 7

[Philipp von Weitershausen [:philikon]]

Yup, chrome mochitest works. See bug 733265.

Comment 8

[Philipp von Weitershausen [:philikon]]

Actually, not an invalid bug, just one we didn't choose to fix this way.