732423 - IonMonkey: Compile JSOP_CALLELEM

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

CALLELEM be mostly identical to GETELEM, only __noSuchMethod__ may need some work. We need to handle this op for box2d/emscripten.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 602394 [details] [diff] [review]
Patch

Review of attachment 602394 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with this fixed (maybe have  a CallElemOperation?)

::: js/src/jsinterp.cpp
@@ +4569,5 @@
>  
>  bool
> +js::CallElement(JSContext *cx, const Value &lref, const Value &rref, Value *res)
> +{
> +    if (!GetElementOperation(cx, lref, rref, res))

This should follow CALLELEM in the interpreter, rather than GETELEM, I think. So, calling ValuePropertyBearer instead of ValueToObject, and js_GetMethod instead of getProperty.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Patch for inbound

This patch coalesces the GETELEM/CALLELEM interpreter cases, and lets stubs::GetElem call GetElementOperation. Also fixes some problems with CALLELEM and e4x/__noSuchMethod__ (see the testcase).

Comment 4

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af6d1d5c7c12

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/af6d1d5c7c12

Comment 6

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/projects/ionmonkey/rev/c9f4c7f87223