732598 - WebGL no longer works on Samsung Galaxy Tab 8.9

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bill Gianopoulos [:WG9s]]

WebGL is not working on my Samsung Galaxy Tab 8.9 with mozilla-inbound builds.

So far have narrowed the reression range to:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e485c2c74c4d&tochange=c30b6943dc98

Comment 1

[Bill Gianopoulos [:WG9s]]

Further narrowed using tinderbox builds to this:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7d4c7ca828a2&tochange=ec9be13d5fad

I suspect Bug 700240.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Optionally load glGetTexLevelParameteriv

Does this fix the issue for you?

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 602522 [details] [diff] [review]
Optionally load glGetTexLevelParameteriv

Review of attachment 602522 [details] [diff] [review]:
-----------------------------------------------------------------

Indeed, glGetTexLevelParameter doesn't exist in ES, so this change presumably broke all strict ES implementations.

r=me but please give this a thought:

::: gfx/gl/GLContext.h
@@ +2136,5 @@
>  
>      void fGetTexLevelParameteriv(GLenum target, GLint level, GLenum pname, GLint *params)
>      {  
> +        if (!mSymbols.fGetTexLevelParameteriv) {
> +          *params = 0;

Unless there is a specific reason to default to 0 here, I would rather leave *params unchanged. That would be in line with the behavior of OpenGL getter functions when an error occurs. Although here, there is no OpenGL error and we don't currently have a good way of simulating one in release builds. (If needed we could still decide to make mGLError work also in release builds, with negligible overhead.)

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Ah no, scrap that, callers calling this with uninitialized *params would find it very surprising if it stayed uninitialized while no GL error occurred. My suggestion only makes sense if we decide to simulate a GL error here.

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Created attachment 602522 [details] [diff] [review]
> Optionally load glGetTexLevelParameteriv
> 
> Does this fix the issue for you?

Yes that works great!

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/788912c80d97

Comment 8

[Bill Gianopoulos [:WG9s]]

https://hg.mozilla.org/mozilla-central/rev/788912c80d97