732642 - mozilla-inbound is broken: pretxnchangegroup.z_loghistory hook raised an exception: column rev is not unique

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Richard Newman [:rnewman]]

+++ This bug was initially created as a clone of Bug #628095 +++

pushing to ssh://hg.mozilla.org/integration/mozilla-inbound
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 10 changesets with 28 changes to 25 files
remote: Trying to insert into pushlog.
remote: Please do not interrupt...
remote: error: pretxnchangegroup.z_loghistory hook raised an exception: column rev is not unique
remote: transaction abort!
remote: rollback completed
remote: ** unknown exception encountered, please report by visiting
remote: **  http://mercurial.selenic.com/wiki/BugTracker
remote: ** Python 2.4.3 (#1, Apr 14 2011, 20:42:01) [GCC 4.1.2 20080704 (Red Hat 4.1.2-50)]
remote: ** Mercurial Distributed SCM (version 2.0.2)
remote: ** Extensions loaded: hgwebjson, pushlog-feed, buglink
remote: Traceback (most recent call last):
remote:   File "/usr/bin/hg", line 38, in ?
remote:     mercurial.dispatch.run()
remote:   File "usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 27, in run
remote:   File "usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 64, in dispatch
remote:   File "usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 87, in _runcatch
remote:   File "usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 684, in _dispatch
remote:   File "usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 466, in runcommand
remote:   File "usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 738, in _runcommand
remote:   File "usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 692, in checkargs
remote:   File "usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 681, in <lambda>
remote:   File "usr/lib/python2.4/site-packages/mercurial/util.py", line 458, in check
remote:   File "/usr/lib/python2.4/commands.py", line 4954, in serve
remote:     
remote:   File "usr/lib/python2.4/site-packages/mercurial/sshserver.py", line 93, in serve_forever
remote:   File "usr/lib/python2.4/site-packages/mercurial/sshserver.py", line 111, in serve_one
remote:   File "usr/lib/python2.4/site-packages/mercurial/wireproto.py", line 344, in dispatch
remote:   File "usr/lib/python2.4/site-packages/mercurial/wireproto.py", line 578, in unbundle
remote:   File "usr/lib/python2.4/site-packages/mercurial/localrepo.py", line 1944, in addchangegroup
remote:   File "usr/lib/python2.4/site-packages/mercurial/localrepo.py", line 239, in hook
remote:   File "/usr/lib/python2.4/site-packages/mercurial/hook.py", line 165, in hook
remote:     r = _pythonhook(ui, repo, name, hname, hookfn, args, throw) or r
remote:   File "/usr/lib/python2.4/site-packages/mercurial/hook.py", line 75, in _pythonhook
remote:     r = obj(ui=ui, repo=repo, hooktype=name, **args)
remote:   File "/usr/lib/python2.4/site-packages/mozhghooks/pushlog.py", line 79, in log
remote:     (pushid, ctx.rev(), hex(ctx.node())))
remote: pysqlite2.dbapi2.IntegrityError: column rev is not unique
abort: unexpected response: empty string

Comment 1

[Ed Morley [:emorley]]

(2012-03-03 01:27:06) jimb: I think I broke inbound.
(2012-03-03 01:27:13) jimb: I hit C-c in the midst of a push, and now https://tbpl.mozilla.org/?tree=Mozilla-Inbound won't load any more. :((((
(2012-03-03 01:28:20) jimb: (It being 5:30 on a Friday, I can't imagine why anyone might be unhappy with me.)

Comment 2

[Ben Kero [:bkero]]

I've pushed the last commit back out of the pushlog, previous occurrences of the same problem were fixed in this way.  Please attempt to commit to verify if my changes worked.

Comment 3

[Ben Kero [:bkero]]

sqlite> select * from pushlog order by id desc limit 10;
6727|[e-mail]|1330737744
6726|[e-mail]|1330732564
6725|[e-mail]|1330731849
6724|[e-mail]|1330731589
6723|[e-mail]|1330728377
6722|[e-mail]|1330728127
6721|[e-mail]|1330727064
6720|[e-mail]|1330727008
6719|[e-mail]|1330726889
6718|[e-mail]|1330726542

sqlite> select * from changesets order by pushid desc limit 10;
6727|88186|27aaea4694b5e04bc249b21185a8afd967f40324
6726|88185|9b0319298e0ebd12cfc9e6777e1c24f059b96b12
6726|88184|065dc9204d09edfd1d9f90a29a665dfcc6846297
6725|88183|c228a0a6f2ceb822edc5700c9a73b89d9159a3cf
6724|88182|2b4aed5ee94e035a7cee32c308ca9b8590a426bb
6723|88181|5a9bd18c627ae6a01f83194345c8785f95b2c664
6722|88180|b0b135e60d351fbbda6987dff6a410771068b855
6721|88179|e365b768a32ebdaa67a4264602d269ed8cbdd571
6720|88178|5d9e5dd1709e675a177efe7100931220a31472ca
6720|88177|031cfd3d00f6a7870e87642d223d41a28e1e1d62

I then check the page https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml to see what commit tip is.  If it's missing on the page, but in the sqlite, delete it from the sqlite!

sqlite> delete from pushlog where id=6727;
sqlite> delete from changesets where pushid=6727;

Comment 4

[Ben Kero [:bkero]]

confirmed fixed on irc