732698 - Update SeaMonkey website project areas

Status: RESOLVED FIXED

(SeaMonkey :: Website, defect)

Description

[Ian Neal]

Attachment: Diff for project areas

After consultation this patch gives an updated version of the projects area page.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Found some differences to your "final draft" v1.3, please explain (no need for a new patch if you explain well :-)). You can see the staging website for what I have right now (your patch, the typo below fixed, plus one missing empty cell added for MailNews).

* "User Interface"/"UI Design" Peers jag/timeless
* "Integration of external apps" location
* you as Peer for "Cross-suite" vs. for "Autocomplete ..."
* you as Peer for "Feed discovery and Preview"
* "Release Engineering": "IanNN" (typo, fixed locally, but please fix in case you provide a new patch) vs "standard8"
* you as Peer for "Security"
* you as Peer for "Session Restore"
* you as Peer for "Startup & Profile"
* you as Peer for "Sync UI"
* you and Callek as Peers for "Testing Infrastructure"
* Callek as Peer vs. Owner for QA

Comment 2

[Ian Neal]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #1)
> Found some differences to your "final draft" v1.3, please explain (no need
> for a new patch if you explain well :-)). You can see the staging website
> for what I have right now (your patch, the typo below fixed, plus one
> missing empty cell added for MailNews).
> 
> * "User Interface"/"UI Design" Peers jag/timeless
These should have been removed.

> * "Integration of external apps" location
This seemed to sit better under cross-suite.

> * you as Peer for "Cross-suite" vs. for "Autocomplete ..."
> * you as Peer for "Feed discovery and Preview"
> * "Release Engineering": "IanNN" (typo, fixed locally, but please fix in
> case you provide a new patch) vs "standard8"
> * you as Peer for "Security"
> * you as Peer for "Session Restore"
> * you as Peer for "Startup & Profile"
> * you as Peer for "Sync UI"
> * you and Callek as Peers for "Testing Infrastructure"
> * Callek as Peer vs. Owner for QA
The two changes for Callek were by his suggestion, the change for me was because I decided enough about Build Config to be an overall peer for Cross-Suite (could argue the same for Release Engineering so making that change too).
We probably need to alter the lines to do with who manages the page too.

Comment 3

[Ian Neal]

(In reply to Ian Neal from comment #2)

> the change for me was
> because I decided I didn't know enough about Build Config to be an overall peer for
> Cross-Suite (could argue the same for Release Engineering so making that
> change too).
Sorry missed some words in that explanation.

Comment 4

[Ian Neal]

Attachment: Revised diff

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 602628 [details] [diff] [review]
Revised diff

So KaiRo is a manager now, is he not? Managers manage. :-) SCNR

OK, so shall we change it to you (Ian) or Council? Certainly not me, I'm only making changes, no? [If you think it should be me, I'd put "Web pages team" or something like that there instead.]

BTW: What are "CVS modules"? Does that still apply, and if not, can it be removed entirely or is there some hg equivalent that would make sense to note?

Comment 6

[Ian Neal]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #5)
> OK, so shall we change it to you (Ian) or Council?
It probably should be the Council.

> BTW: What are "CVS modules"? Does that still apply, and if not, can it be
> removed entirely or is there some hg equivalent that would make sense to
> note?
I'm not aware of anything equivalent in hg, unless KaiRo knows better, so that first sentence probably does need fixing too.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Ian, how about the following (cf. staging website)?

<p>
-The project areas list acts as a "master list" for several other things:
-Most importantly,
+The project areas list describes who can review which part of the
+SeaMonkey code base.
 <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=298904">SeaMonkey's
-Bugzilla components list</a> gets derived from it, but also things like CVS
-modules are based on or related to it. It's similar in purpose to the
+Bugzilla components list</a> gets derived from it.
+It's similar in purpose to the
 <a href="http://www.mozilla.org/owners.html">Mozilla Module Owners</a>
 list, and the
 <a href="http://www.mozilla.org/hacking/module-ownership.html">Module
@@ -28,9 +28,8 @@
 Module Ownership" section.
 Additionally, <a href="review-and-flags">SeaMonkey code reviews</a> need
 to be done by area owners or peers listed in this document.
-<br>The list is managed by Robert Kaiser (KaiRo)
-&lt;<a href="mailto:[e-mail]">[e-mail]</a>&gt;,
-contact him with any comments or suggestions for changes.
+<br>The list is managed by the SeaMonkey Council; contact us
+with any comments or suggestions for changes.
 <br>Note that only the owner of an area (or its parent area) or the SeaMonkey
 Council can decide on changes for a specific area.

Comment 8

[Ian Neal]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #7)
> Ian, how about the following (cf. staging website)?
> 
> <p>
> -The project areas list acts as a "master list" for several other things:
> -Most importantly,
> +The project areas list describes who can review which part of the
> +SeaMonkey code base.
>  <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=298904">SeaMonkey's
> -Bugzilla components list</a> gets derived from it, but also things like CVS
> -modules are based on or related to it. It's similar in purpose to the
> +Bugzilla components list</a> gets derived from it.
> +It's similar in purpose to the
>  <a href="http://www.mozilla.org/owners.html">Mozilla Module Owners</a>
>  list, and the
>  <a href="http://www.mozilla.org/hacking/module-ownership.html">Module
> @@ -28,9 +28,8 @@
>  Module Ownership" section.
>  Additionally, <a href="review-and-flags">SeaMonkey code reviews</a> need
>  to be done by area owners or peers listed in this document.
> -<br>The list is managed by Robert Kaiser (KaiRo)
> -&lt;<a href="mailto:[e-mail]">[e-mail]</a>&gt;,
> -contact him with any comments or suggestions for changes.
> +<br>The list is managed by the SeaMonkey Council; contact us
> +with any comments or suggestions for changes.
>  <br>Note that only the owner of an area (or its parent area) or the
> SeaMonkey
>  Council can decide on changes for a specific area.

Looks good to me.

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Checking in src/dev/project-areas.en.html;
/www/seamonkeyproject-org/src/dev/project-areas.en.html,v  <--  project-areas.en.html
new revision: 1.8; previous revision: 1.7
done

Next:
* https://wiki.mozilla.org/Modules/All#SeaMonkey
* https://wiki.mozilla.org/Modules/SeaMonkey

Does the fact that it's a wiki imply that either you or me *can* and *may* apply the changes there right away, or do we need to get approval of some sort, or even let someone do it for us? :-/

Comment 10

[Serge Gautherie (:sgautherie)]

<a href="http://www.mozilla.org/owners.html">Mozilla Module Owners</a>
is now an alias (only) and should be updated to point to
https://wiki.mozilla.org/Modules

Comment 11

[Ian Neal]

Attachment: Fix misalignment

Fixes an issue I spotted with the MailNews heading.

Comment 12

[Ian Neal]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #9)
> Checking in src/dev/project-areas.en.html;
> /www/seamonkeyproject-org/src/dev/project-areas.en.html,v  <-- 
> project-areas.en.html
> new revision: 1.8; previous revision: 1.7
> done
> 
> Next:
> * https://wiki.mozilla.org/Modules/All#SeaMonkey
> * https://wiki.mozilla.org/Modules/SeaMonkey
> 
> Does the fact that it's a wiki imply that either you or me *can* and *may*
> apply the changes there right away, or do we need to get approval of some
> sort, or even let someone do it for us? :-/

I think I have done them now, please check for errors.

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 602773 [details] [diff] [review]
Fix misalignment

Checking in src/dev/project-areas.en.html;
/www/seamonkeyproject-org/src/dev/project-areas.en.html,v  <--  project-areas.en.html
new revision: 1.9; previous revision: 1.8
done

Comment 14

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Serge Gautherie (:sgautherie) from comment #10)
> <a href="http://www.mozilla.org/owners.html">Mozilla Module Owners</a>
> is now an alias (only) and should be updated to point to
> https://wiki.mozilla.org/Modules

Checking in src/dev/project-areas.en.html;
/www/seamonkeyproject-org/src/dev/project-areas.en.html,v  <--  project-areas.en.html
new revision: 1.10; previous revision: 1.9
done

Comment 15

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Ian Neal from comment #12)
> I think I have done them now, please check for errors.

OK, went through it now. Nits:

"MailNews: General" has no entry on the wiki, i.e. the component is not listed. Not a big deal, but I thought I should mention it.

Help: stefanh's link is broken

In general: Let's better use the naming scheme the TB guys are using, since that is a better compromise between what the other products are using (real name only) and what we have right now. I.e. it should look like this:
  _first and last name_ (:nick) (role)
  e.g.
  _Jens Hatlak_ (:InvisibleSmiley) (release notes)
  I think the only exceptions would be db48x and stefanh.

Comment 16

[Ian Neal]

Yes, I was working from the format of the original SeaMonkey modules page and it was only when I got to the end that I spotted that TB was using, probably a better format.
I will look at changing it to that format.

Comment 17

[Ian Neal]

The other thing that TB do is for unowned modules they have:
(Unowned - ask a Thunderbird owner or peer for review)
Should we look at similar for SM?

Comment 18

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Ian Neal from comment #17)
> The other thing that TB do is for unowned modules they have:
> (Unowned - ask a Thunderbird owner or peer for review)
> Should we look at similar for SM?

Sure; probably better than implying Neil is actually a module's owner when he is more like a super-owner. ;-)

Comment 19

[Ian Neal]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #18)
> (In reply to Ian Neal from comment #17)
> > The other thing that TB do is for unowned modules they have:
> > (Unowned - ask a Thunderbird owner or peer for review)
> > Should we look at similar for SM?
> 
> Sure; probably better than implying Neil is actually a module's owner when
> he is more like a super-owner. ;-)

Ok, updated, added some source dir(s) where I knew, feel free to correct/add/remove.

Comment 20

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Ian Neal from comment #19)
> Ok, updated, added some source dir(s) where I knew, feel free to
> correct/add/remove.

For now I only clarified the test source directories list (there's more than just common/, and both "test" and "tests") and upper-cased the nicks of Callek and KaiRo (no idea why the TB guys thinks all lower case is better; I think it's not) but let the rest as-is for now.

[<rant>Actually I think Bugzilla should have a nickname field as part of user preferences, and this one should be mandatory to fill in for anyone trying to set a flag. I'm so sick of "bugzilla: review+" and the like. Am I alone with this? I cannot be the first to suggest it, can I?</rant>]

Comment 21

[Tony Mechelynck [:tonymec]]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #20)
[...]
> [<rant>Actually I think Bugzilla should have a nickname field as part of
> user preferences, and this one should be mandatory to fill in for anyone
> trying to set a flag. I'm so sick of "bugzilla: review+" and the like. Am I
> alone with this? I cannot be the first to suggest it, can I?</rant>]

How is it done now? Ah yeah, the part of the email handle before the @. Maybe:
- nickname, if any, otherwise        (e.g. for me: :tonymec)
- "Real Name", if set, otherwise     (e.g. for me: Tony Mechelynck)
- full email-address-of-record       (e.g. for me: [e-mail])
All three can change over time though, and Bugzilla will update them to the current value, even in comments, flags, etc., set before the change.

Comment 22

[Robert Kaiser]

There's open Bugzilla bugs on those things, better take your ideas and wishes there. :)