732715 - Documentation bug in Add-on SDK Annotator example

Status: RESOLVED INACTIVE

(Mozilla Labs :: Jetpack SDK, defect)

Description

[David Y. Kay]

Attachment: Screen Shot 2012-03-03 at 1.24.50 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120215223356

Steps to reproduce:

I was working through the Add-On SDK 1.5 examples at: https://addons.mozilla.org/en-US/developers/docs/sdk/latest/dev-guide/addon-development/annotator/widget.html

And found that the first code example, "The Widget's Content Script," is broken. It's missing some boolean operators.


Actual results:

Source code example reads:

this.addEventListener('click', function(event) {
  if(event.button == 0  event.shiftKey == false)
    self.port.emit('left-click');
 
  if(event.button == 2 || (event.button == 0  event.shiftKey == true))
    self.port.emit('right-click');
    event.preventDefault();
}, true);



Expected results:

It should read:

this.addEventListener('click', function(event) {
  if(event.button == 0 && event.shiftKey == false)
    self.port.emit('left-click');

  if(event.button == 2 || (event.button == 0 && event.shiftKey == true))
    self.port.emit('right-click');
    event.preventDefault();
}, true);

Comment 1

[David Y. Kay]

My first bug on here. Sorry if this is in the wrong place!

Comment 2

[Clauber Stipkovic [:cstipkovic]]

Hey David!
The link that you informed in not working. Could you please send me the link again? Thanks!

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Closing all inactive bugs in Mozilla labs :: *
Please reopen if this are still relevant.