732746 - Prompt service should support multiple inputs of the same type

Status: RESOLVED DUPLICATE of bug 830175

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch

For one of my extensions, I want to menulists in a prompt dialog. We can do that right now, but in the return value, we only return one type of boxes values (i.e. the return looks like: { menulist: "0" }. We should support putting multiple inputs of the same type on a dialog at the same time (I think we luck out with username+password because, while they're both textboxes, one is a password type textbox and the other is normal).

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 602675 [details] [diff] [review]
Patch


>     private class PromptInput {
>         private String label = "";
>         private String type  = "";
>         private String hint  = "";
>+        private String id    = "";

Remove the extra spaces please (in the other lines too)

Seems like a simple patch. Is this all that's needed?

Comment 2

[Wesley Johnston (:wesj)]

Yep. With this callers can specify an with the message like:

msg = {
  type: "Prompt:Show",
  inputs: [
    { type: "text" },
    { type: "text", id: "myText2" },
  ]
}

and get back a result like:

{ text: "text1", myText2: "text2" }

if they don't pass in an id they will receive:

{ text: "text2" }

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I assume this would work too:

msg = {
  type: "Prompt:Show",
  inputs: [
    { type: "text", id: "myText1" },
    { type: "text", id: "myText2" },
  ]
}

Comment 4

[Wesley Johnston (:wesj)]

Yep. :) Should at least. I'll double check through my addon before I check in. And start looking at hooking up some Robotium soon too.

Comment 5

[Wesley Johnston (:wesj)]

I knew I fixed this, but forgot to check it in. kats fixed it in bug 830175 again. Closing.