Fix include paths in <script type="application/javascript" src="amUtils.js"/> to 'chrome://messenger/content/amUtils.js'

RESOLVED FIXED in Thunderbird 14.0

Status

MailNews Core
Account Manager
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 14.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

10.68 KB, patch
standard8
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
There are several occurrences of this style in the /mailnews/ tree.
(Assignee)

Comment 1

6 years ago
Created attachment 602726 [details] [diff] [review]
fix

I am not sure about the gloda path.
Attachment #602726 - Flags: review?(iann_bugzilla)
Attachment #602726 - Flags: feedback?(jonathan.protzenko)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Comment on attachment 602726 [details] [diff] [review]
fix

That looks like a valid path (for Thunderbird). Out of curiosity, why the cleanup? Did someone rule that it was bad practice to use relative paths in overlays now?
Attachment #602726 - Flags: feedback?(jonathan.protzenko) → feedback+
(Assignee)

Comment 3

6 years ago
No, I just thought to clean it up because the prevailing style was to use absolute paths. I do not know if it is bad or good. Let's see what Ian and Mark say.

Comment 4

6 years ago
Comment on attachment 602726 [details] [diff] [review]
fix

>+++ b/mailnews/base/prefs/content/SmtpServerEdit.xul
>+<script type="application/javascript" src="chrome://messenger/content/amUtils.js"/>
>+<script type="application/javascript" src="chrome://messenger/content/SmtpServerEdit.js"/>
Nit: as over 80 characters have src on separate line for each of the above.

>+++ b/mailnews/base/prefs/content/am-identities-list.xul
>+<script type="application/javascript" src="chrome://messenger/content/am-identities-list.js"/>
Nit: as over 80 characters have src on separate line.

>+++ b/mailnews/base/prefs/content/am-identity-edit.xul
>+  <script type="application/javascript" src="chrome://messenger/content/am-identity-edit.js"/>
Nit: as over 80 characters have src on separate line.

>+++ b/mailnews/base/prefs/content/am-server-advanced.xul
>+  <script type="application/javascript" src="chrome://messenger/content/am-server-advanced.js"/>
Nit: as over 80 characters have src on separate line.

>+++ b/mailnews/base/prefs/content/am-smtp.xul
>+  <script type="application/javascript" src="chrome://messenger/content/amUtils.js"/>
>+  <script type="application/javascript" src="chrome://messenger/content/am-smtp.js"/>
Nit: as over 80 characters have src on separate line for each of the above.

>+++ b/mailnews/base/prefs/content/smtpEditOverlay.xul
>+  <script type="application/javascript" src="chrome://messenger/content/smtpEditOverlay.js"/>
Nit: as over 80 characters have src on separate line.

>+++ b/mailnews/db/gloda/content/thunderbirdOverlay.xul
>+  <script src="chrome://gloda/content/overlay.js"/>
Nit: you add type here too and as it will be over 80 characters have src on separate line.

r=me with those fixed
Attachment #602726 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 602966 [details] [diff] [review]
fix v2

Thanks, done.
Attachment #602726 - Attachment is obsolete: true
Attachment #602966 - Flags: review?(mbanner)
Attachment #602966 - Flags: review?(mbanner) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/9890feabdc74
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.