732807 - convert mailnews/extensions/smime to Services.jsm

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[:aceman]

Convert some mailnews/extensions/smime/* calls from Components.classes[*] to Services.jsm:

am-smime.js:  var prefService = Components.classes["@mozilla.org/preferences-service;1"].getService(Components.interfaces.nsIPrefService);
am-smime.js:  var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService();
am-smime.js:  var windowMediator = Components.classes["@mozilla.org/appshell/window-mediator;1"]
am-smime.js:  var windowMediator = Components.classes["@mozilla.org/appshell/window-mediator;1"]
certFetchingStatus.js:    Components.classes["@mozilla.org/preferences-service;1"]
certFetchingStatus.js:    gLdapServerURL = Components.classes["@mozilla.org/network/io-service;1"]
certFetchingStatus.js:    var windowWatcherSvc = Components.classes["@mozilla.org/embedcomp/window-watcher;1"]
msgCompSecurityInfo.js:        Components.classes["@mozilla.org/preferences-service;1"]
msgCompSMIMEOverlay.js:  let promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
msgReadSMIMEOverlay.js:  let promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 602733 [details] [diff] [review]
patch

This is a simple replacement of services etc, with no functional change, so I can review this as I know kaie is busy.

Comment 3

[Kai Engert (:KaiE:)]

Comment on attachment 602733 [details] [diff] [review]
patch

Mark, thanks for your offer to review this code, sounds good to me.

Comment 4

[:aceman]

Mark is quite busy too :)

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 602733 [details] [diff] [review]
patch

Review of attachment 602733 [details] [diff] [review]:
-----------------------------------------------------------------

Basically good, but a couple of improvements to be made.

::: mailnews/extensions/smime/content/certFetchingStatus.js
@@ +74,5 @@
>  }
>  
>  function search()
>  {
> +  let prefs = Services.prefs.getBranch(null);

Services.prefs.getBranch(null) is basically equivalent to Services.prefs - hence I think you can drop the .getBranch and inline the local variable.

::: mailnews/extensions/smime/content/msgCompSecurityInfo.js
@@ +154,2 @@
>        var autocompleteLdap = false;
> +      autocompleteLdap = Services.prefs.getBranch(null)

ditto in this file with the .getBranch(null)

Comment 6

[:aceman]

Thanks, I wasn't sure what is the effect of getBranch(null) so I preserved it.

Comment 7

[:aceman]

Attachment: patch v2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/01a7a15d27bf