732914 - Permanent orange: TEST-UNEXPECTED-FAIL | test_traits.js | money == lots

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Mark Banner (:standard8)]

Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fd92f3c7ad11&tochange=ed57abebd328

Log:

http://tinderbox.mozilla.org/showlog.cgi?tree=ThunderbirdTrunk&errorparser=unittest&logfile=1330920414.1330921032.19836.gz&buildtime=1330920414&buildname=Linux%20comm-central%20test%20xpcshell&fulltext=1#err0

TEST-PASS | /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/mailnews/extensions/bayesian-spam-filter/test/unit/test_traits.js | [null : 161] 95 == 95
StartCommand command = 3, remaining tests 5
Directory request for: UMimTyp that we (mailDirService.js) are not handling, leaving it to another handler.
Details for file:///buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/mailnews/extensions/bayesian-spam-filter/test/unit/resources/spam2.eml?type=application/x-message-display
Percent 84 Running 84 Token money

TEST-UNEXPECTED-FAIL | /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/mailnews/extensions/bayesian-spam-filter/test/unit/test_traits.js | money == lots - See following stack:
JS frame :: /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/head.js :: do_throw :: line 462
JS frame :: /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/head.js :: _do_check_eq :: line 556
JS frame :: /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/head.js :: do_check_eq :: line 577
JS frame :: /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/mailnews/extensions/bayesian-spam-filter/test/unit/test_traits.js :: <TOP_LEVEL> :: line 184

This could just be an ordering thing, but I'm trying to isolate the specific bug that caused this.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

The regression point is bug 729952 which has the side-effect of changing the order of hash keys. As a result, iterators can't depend on that order. Therefore we take the dependence out of the test.

Comment 2

[David :Bienvenu]

Comment on attachment 602981 [details] [diff] [review]
The fix

fixes it for me.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 602981 [details] [diff] [review]
The fix

http://hg.mozilla.org/comm-central/rev/1d32da8f93d1