Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Permanent orange: TEST-UNEXPECTED-FAIL | test_traits.js | money == lots

RESOLVED FIXED in Thunderbird 13.0

Status

MailNews Core
Filters
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({intermittent-failure, regression})

Trunk
Thunderbird 13.0
intermittent-failure, regression
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fd92f3c7ad11&tochange=ed57abebd328

Log:

http://tinderbox.mozilla.org/showlog.cgi?tree=ThunderbirdTrunk&errorparser=unittest&logfile=1330920414.1330921032.19836.gz&buildtime=1330920414&buildname=Linux%20comm-central%20test%20xpcshell&fulltext=1#err0

TEST-PASS | /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/mailnews/extensions/bayesian-spam-filter/test/unit/test_traits.js | [null : 161] 95 == 95
StartCommand command = 3, remaining tests 5
Directory request for: UMimTyp that we (mailDirService.js) are not handling, leaving it to another handler.
Details for file:///buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/mailnews/extensions/bayesian-spam-filter/test/unit/resources/spam2.eml?type=application/x-message-display
Percent 84 Running 84 Token money

TEST-UNEXPECTED-FAIL | /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/mailnews/extensions/bayesian-spam-filter/test/unit/test_traits.js | money == lots - See following stack:
JS frame :: /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/head.js :: do_throw :: line 462
JS frame :: /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/head.js :: _do_check_eq :: line 556
JS frame :: /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/head.js :: do_check_eq :: line 577
JS frame :: /buildbot/comm-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/mailnews/extensions/bayesian-spam-filter/test/unit/test_traits.js :: <TOP_LEVEL> :: line 184

This could just be an ordering thing, but I'm trying to isolate the specific bug that caused this.
Whiteboard: [tb-orange]
Assignee: nobody → mbanner
Created attachment 602981 [details] [diff] [review]
The fix

The regression point is bug 729952 which has the side-effect of changing the order of hash keys. As a result, iterators can't depend on that order. Therefore we take the dependence out of the test.
Attachment #602981 - Flags: review?(dbienvenu)
Blocks: 729952

Comment 2

5 years ago
Comment on attachment 602981 [details] [diff] [review]
The fix

fixes it for me.
Attachment #602981 - Flags: review?(dbienvenu) → review+
Comment on attachment 602981 [details] [diff] [review]
The fix

http://hg.mozilla.org/comm-central/rev/1d32da8f93d1
Attachment #602981 - Attachment description: The fix → The fix [Checked in: Comment 3]
Flags: in-testsuite+
Target Milestone: --- → Thunderbird 13.0
Version: unspecified → Trunk
Attachment #602981 - Attachment description: The fix [Checked in: Comment 3] → The fix
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Keywords: intermittent-failure
Whiteboard: [tb-orange]
You need to log in before you can comment on or make changes to this bug.