732918 - lzma checkin broke Xcode build

Status: RESOLVED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

xcodebuild -project avmshell.xcodeproj ONLY_ACTIVE_ARCH=NO ARCHS="x86_64 i386" -configuration Debug -target avm+avm64 build

yields:

Undefined symbols:
  "_MyAlloc", referenced from:
      avmplus::SzAlloc(void*, unsigned long)in ByteArrayGlue.o
  "_LzmaUncompress", referenced from:
      avmplus::ByteArray::Uncompress(avmplus::ByteArray::CompressionAlgorithm)in ByteArrayGlue.o
  "_LzmaDynamicEncode", referenced from:
      avmplus::ByteArray::LzmaEncoder::Encode()    in ByteArrayGlue.o
  "_MyFree", referenced from:
      avmplus::SzFree(void*, void*)in ByteArrayGlue.o
  "_LzmaEncProps_Init", referenced from:
      avmplus::ByteArray::LzmaEncoder::Encode()    in ByteArrayGlue.o
ld: symbol(s) not found


This is analogous to Bug 732057; the Xcode project files need to be updated for the lzma checkin from Bug 729336.

Comment 1

[Tamarin Bot]

changeset: 7249:c9134c323179
user:      Felix S Klock II <[e-mail]>
summary:   Bug 732918: add lzma project to xcode (r=fklockii).

http://hg.mozilla.org/tamarin-redux/rev/c9134c323179

Comment 2

[Tamarin Bot]

changeset: 7272:bf4b6d01f51d
user:      Felix Klock II <[e-mail]>
summary:   Bug 732918: xcode project fixes for lzma (r=fklockii).

http://hg.mozilla.org/tamarin-redux/rev/bf4b6d01f51d

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

There are still kinks to be ironed out.

Works:

  xcodebuild -project avmshell.xcodeproj ONLY_ACTIVE_ARCH=NO ARCHS="x86_64 i386" \
  -configuration Debug -target avm+avm64 build


Breaks:

  xcodebuild -project avmshell.xcodeproj ONLY_ACTIVE_ARCH=NO ARCHS="x86_64 i386" \
  -configuration Debug_Debugger -target avm+avm64 build

  xcodebuild -project avmshell.xcodeproj ONLY_ACTIVE_ARCH=NO ARCHS="x86_64 i386" \
  -configuration Release -target avm+avm64 build

  xcodebuild -project avmshell.xcodeproj ONLY_ACTIVE_ARCH=NO ARCHS="x86_64 i386" \
  -configuration Release_Debugger -target avm+avm64 build

(sigh, I thought I tested it, but I obviously missed at least one of the cases in 3/4 of the classes of builds of interest.)

Comment 4

[Felix S. Klock II [:pnkfelix, :fklock]]

(it looks like the issue is with the 64-bit builds; the lzma64 build is being put into the Release/ directory instead of the Release64/ directory, for better or for worse.  Obviously there are at least two ways to fix that.)

Comment 5

[Felix S. Klock II [:pnkfelix, :fklock]]

(woot, killed two birds with one stone by fixing Bug 668836 in parallel.  I have to run but I do hope to push the results to TR (and elsewhere) later tonight.)

Comment 6

[Tamarin Bot]

changeset: 7288:70f43c112ce1
user:      Felix Klock II <[e-mail]>
summary:   Bug 732918, 668836: fix lzma build and bulk-migrate lzma settings out of pbxproj and into xcconfig files (r=fklockii).

http://hg.mozilla.org/tamarin-redux/rev/70f43c112ce1