Closed
Bug 732939
Opened 13 years ago
Closed 7 years ago
acceptance/runtests.py should support --showtimes for AOT compile to log build time
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: dschaffe, Unassigned)
Details
Attachments
(1 file, 3 obsolete files)
|
8.60 KB,
patch
|
Details | Diff | Splinter Review |
In runtestBase.py the --showtimes should output the time to compile each test from adt. We could output a format like:
AOT compiling abcasm/bug_558442.abc time 660.0
The --logjunit flag could parse the output to include the aot time.
|
Reporter | |
Comment 1•13 years ago
|
||
|
|
Reporter | |
Comment 2•13 years ago
|
||
Attachment #602865 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 3•13 years ago
|
||
Attachment #602868 -
Attachment is obsolete: true
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 602870 [details] [diff] [review]
patch
Review of attachment 602870 [details] [diff] [review]:
-----------------------------------------------------------------
::: test/util/runtestBase.py
@@ +1213,3 @@
> (f,err,exitcode) = self.compile_aot(testdir+".abc", [self.abcasmShell+'.abc'])
> + if self.show_time:
> + self.js_print('AOT compiling %s time %.1f' % (testdir+".abc",time.time()-start_time))
Should we be tracking compilation time if compilation failed?
|
|
Reporter | |
Comment 5•13 years ago
|
||
|
|
Reporter | |
Updated•13 years ago
|
Attachment #602870 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•13 years ago
|
Attachment #603686 -
Attachment is patch: true
|
|
||
Comment 6•13 years ago
|
||
changeset: 7259:782d8f327cca
user: Dan Schaffer <dschaffe@adobe.com>
summary: Bug 732939: log compilation time for AOT during --rebuildtests (r+brbaker)
http://hg.mozilla.org/tamarin-redux/rev/782d8f327cca
|
|
||
Comment 7•13 years ago
|
||
changeset: 7259:782d8f327cca
user: Dan Schaffer <dschaffe@adobe.com>
summary: Bug 732939: log compilation time for AOT during --rebuildtests (r+brbaker)
http://hg.mozilla.org/tamarin-redux/rev/782d8f327cca
|
|
||
Comment 8•13 years ago
|
||
changeset: 7268:511843343487
user: Dan Schaffer <Dan.Schaffer@adobe.com>
summary: bug 732939: fixes for logging AOT compilation to junit xml format
http://hg.mozilla.org/tamarin-redux/rev/511843343487
|
|
||
Comment 9•13 years ago
|
||
changeset: 7325:a645ccd0a56a
user: Dan Schaffer <Dan.Schaffer@adobe.com>
summary: bug 732939: fix aot --showtimes parsing bug for junit xml report generation.
http://hg.mozilla.org/tamarin-redux/rev/a645ccd0a56a
|
|
||
Comment 10•13 years ago
|
||
changeset: 7331:2e66898b6637
user: Dan Schaffer <Dan.Schaffer@adobe.com>
summary: bug 732939: fixes for junit reporting xml
http://hg.mozilla.org/tamarin-redux/rev/2e66898b6637
|
||
Comment 11•7 years ago
|
||
Tamarin is a dead project now. Mass WONTFIX.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
|
|
||
Comment 12•7 years ago
|
||
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
You need to log in
before you can comment on or make changes to this bug.
Description
•