73294 - BodyFixupRule should not kick in in XHTML

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Hixie (not reading bugmail)]

Per the CSS and HTML working groups, the BodyFixupRule only applies to HTML4.x.
We are currently also doing it on XHTML too.

Test case coming up.

Comment 1

[Hixie (not reading bugmail)]

Attachment: Simple and self explanatory testcase. Output should be green, not red.

Comment 2

[Hixie (not reading bugmail)]

See http://lists.w3.org/Archives/Member/w3c-css-wg/2001JanMar/0388.html

Comment 3

[Hixie (not reading bugmail)]

Attachment: Patch: wraps the test for useBodyFixupRule in a check that ensures the document is an nsIHTMLDocument

Comment 4

[Hixie (not reading bugmail)]

See test cases at:
   http://www.hixie.ch/tests/adhoc/css/background/01.html -- 20.html

Looking for an r= and an sr=, then someone to check this in for me -- cheers!

Comment 5

[Marc Attinasi]

Very nice. [s]r=attinasi, and I'll be happy to check it in for you if you want.

Comment 6

[tor]

r=tor

Comment 7

[Blake Ross]

Fix checked in per request.

Comment 8

[Axel Hecht]

The XSLT engine uses XHTML as a hack for the html output method. As we have to
use a XML document, there is no way to make that a HTML document. Hrm.
This checkin causes the html output method of XSLT to regress.
Peter, I reversed the attached patch, and the grey border was gone.

Putting Peter, Heikki and me on CC, any ideas?

Axel

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Isn't the solution to set the background color on HTML rather than BODY?

Comment 10

[Hixie (not reading bugmail)]

Yes, as discussed in the CSS working group.

Comment 11

[Chris Petersen]

Marking verified in the May 21 build.

Comment 12

[David Hyatt]

Hixie, I would greatly appreciate it if you would check this fix in to the 
style branch.

Comment 13

[David Hyatt]

Unless i've already got it of course. :)

Comment 14

[Hixie (not reading bugmail)]

hyatt: Are you sure you've got the right bug? This was checked in months ago.