Last Comment Bug 732946 - IonMonkey: when writing ImmGCPtr's make sure there is enough room for any immediate
: IonMonkey: when writing ImmGCPtr's make sure there is enough room for any imm...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: ARM Linux
: -- normal (vote)
: ---
Assigned To: general
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-05 06:24 PST by Marty Rosenberg [:mjrosenb]
Modified: 2012-03-16 16:19 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
/home/mrosenberg/patches/fixTracing-r0.patch (3.53 KB, patch)
2012-03-05 06:24 PST, Marty Rosenberg [:mjrosenb]
jdemooij: review+
Details | Diff | Splinter Review

Description Marty Rosenberg [:mjrosenb] 2012-03-05 06:24:48 PST
Created attachment 602873 [details] [diff] [review]
/home/mrosenberg/patches/fixTracing-r0.patch

I was just using the standard mov, which will cause grief if the initial value is small, and we later want to replace it with a larger value.  Smaller loads are also not tracked by the tracer.
Comment 1 Jan de Mooij [:jandem] 2012-03-05 06:59:26 PST
Comment on attachment 602873 [details] [diff] [review]
/home/mrosenberg/patches/fixTracing-r0.patch

Review of attachment 602873 [details] [diff] [review]:
-----------------------------------------------------------------

We discussed this patch on IRC, looks fine.

::: js/src/ion/arm/Assembler-arm.cpp
@@ +398,5 @@
>      }
>      
>      for (int i = 0; i < tmpDataRelocations_.length(); i++) {
>          int offset = tmpDataRelocations_[i].getOffset();
> +        int real_offset=offset + m_buffer.poolSizeBefore(offset);

Nit: spaces around the "=".
Comment 2 Marty Rosenberg [:mjrosenb] 2012-03-16 16:19:58 PDT
landed: http://hg.mozilla.org/projects/ionmonkey/rev/bd6f0d827457

Note You need to log in before you can comment on or make changes to this bug.