Closed
Bug 732946
Opened 12 years ago
Closed 12 years ago
IonMonkey: when writing ImmGCPtr's make sure there is enough room for any immediate
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mjrosenb, Unassigned)
Details
Attachments
(1 file)
3.53 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
I was just using the standard mov, which will cause grief if the initial value is small, and we later want to replace it with a larger value. Smaller loads are also not tracked by the tracer.
Attachment #602873 -
Flags: review?(jdemooij)
Comment 1•12 years ago
|
||
Comment on attachment 602873 [details] [diff] [review] /home/mrosenberg/patches/fixTracing-r0.patch Review of attachment 602873 [details] [diff] [review]: ----------------------------------------------------------------- We discussed this patch on IRC, looks fine. ::: js/src/ion/arm/Assembler-arm.cpp @@ +398,5 @@ > } > > for (int i = 0; i < tmpDataRelocations_.length(); i++) { > int offset = tmpDataRelocations_[i].getOffset(); > + int real_offset=offset + m_buffer.poolSizeBefore(offset); Nit: spaces around the "=".
Attachment #602873 -
Flags: review?(jdemooij) → review+
Reporter | ||
Comment 2•12 years ago
|
||
landed: http://hg.mozilla.org/projects/ionmonkey/rev/bd6f0d827457
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•