IonMonkey: when writing ImmGCPtr's make sure there is enough room for any immediate

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mjrosenb, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 602873 [details] [diff] [review]
/home/mrosenberg/patches/fixTracing-r0.patch

I was just using the standard mov, which will cause grief if the initial value is small, and we later want to replace it with a larger value.  Smaller loads are also not tracked by the tracer.
Attachment #602873 - Flags: review?(jdemooij)
Comment on attachment 602873 [details] [diff] [review]
/home/mrosenberg/patches/fixTracing-r0.patch

Review of attachment 602873 [details] [diff] [review]:
-----------------------------------------------------------------

We discussed this patch on IRC, looks fine.

::: js/src/ion/arm/Assembler-arm.cpp
@@ +398,5 @@
>      }
>      
>      for (int i = 0; i < tmpDataRelocations_.length(); i++) {
>          int offset = tmpDataRelocations_[i].getOffset();
> +        int real_offset=offset + m_buffer.poolSizeBefore(offset);

Nit: spaces around the "=".
Attachment #602873 - Flags: review?(jdemooij) → review+
(Reporter)

Comment 2

6 years ago
landed: http://hg.mozilla.org/projects/ionmonkey/rev/bd6f0d827457
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.