732981 - sourceEditor.setCaretPosition() has undefined out of bounds behavior

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect, P3)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

If you attempt to go to a line that does not exist using sourceEditor.setCaretPosition() the current behavior is to do nothing.

If a user attempts to go to a line below 0 the editor should go to line 0 and is a user attempts to go to a line past the end of the file the editor should go to the last line of the file.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Moving to Source Editor component.

Filter on CHELICERAE.

Comment 2

[Mihai Sucan [:msucan]]

Attachment: proposed patch

Simple and quick fix.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 644956 [details] [diff] [review]
proposed patch

looks good.

Comment 4

[Anton Kovalyov (:anton)]

I think CodeMirror.setCursor's behavior is good now. When you go to the <0 line it defaults to 0. When you go to >maxline it defaults to maxline.