"failed to cleanup" message should be more helpful

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: k0scist, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
http://hg.mozilla.org/build/talos/file/6694f881a3fb/talos/ffprocess.py#l91

This isn't very helpful for diagnosis.  We should output more about
the process information for diagnosis
(Reporter)

Comment 1

7 years ago
Created attachment 602937 [details] [diff] [review]
print out running processes
Attachment #602937 - Flags: review?(jmaher)
Comment on attachment 602937 [details] [diff] [review]
print out running processes

Review of attachment 602937 [details] [diff] [review]:
-----------------------------------------------------------------

::: talos/ffprocess.py
@@ +88,5 @@
>              # and we need to give it a little extra time to complete
>              time.sleep(browser_wait)
> +            processes = self.checkAllProcesses(process_name, child_process):
> +            if processes:
> +                raise talosError("failed to cleanup processes: %s" % processes)

I would like to make this more robust:
msg = "Failed to cleanup, no processes found"
if processes:
    msg = "Failed to cleanup processes: %s" % processes
raise talosError(msg)
Attachment #602937 - Flags: review?(jmaher) → review+
(Reporter)

Comment 3

7 years ago
If no processes are found, then cleanup is successful, and we don't raise a talosError
(Reporter)

Updated

7 years ago
Whiteboard: [talos-checkin-needed]
(Reporter)

Comment 4

7 years ago
beh, forgot to remove a ':'
(Reporter)

Comment 5

7 years ago
Created attachment 603015 [details] [diff] [review]
oops
Attachment #602937 - Attachment is obsolete: true
Attachment #603015 - Flags: review?(jmaher)
Attachment #603015 - Flags: review?(jmaher) → review+
(Reporter)

Comment 6

7 years ago
tested locally on android ts + tsvg

Comment 8

7 years ago
Try run for 6dbeb77e5f31 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6dbeb77e5f31
Results (out of 39 total builds):
    exception: 19
    success: 5
    failure: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jhammel@mozilla.com-6dbeb77e5f31
(Reporter)

Comment 9

7 years ago
try looks pretty green, pushing: http://hg.mozilla.org/build/talos/rev/6694f881a3fb
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 10

7 years ago
Try run for b997c2d57863 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b997c2d57863
Results (out of 73 total builds):
    success: 70
    failure: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jhammel@mozilla.com-b997c2d57863
 Timed out after 06 hours without completing.
Whiteboard: [talos-checkin-needed]
You need to log in before you can comment on or make changes to this bug.