733045 - installing bootstrapped add-on directly after uninstalling it disabled results in disabled install

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Dietrich Ayala (:dietrich)]

STR:

1. install a restartless add-on
2. disable it
3. uninstall it
4. install it

Expected: add-on is installed and enabled

Actual: add-on is installed and disabled

post-uninstall, any action should be as on a blank slate. the state of a previous installation has leaked into the subsequent install.

Comment 1

[Dave Townsend [:mossop]]

Can you give more precise STR here, what were you doing with the UI to do all of these things?

Comment 2

[Dietrich Ayala (:dietrich)]

Revised STR:

1. install a restartless add-on
2. disable it some point later (weeks? months?)
3. let time pass, many browsing sessions, etc
4. open add-ons manager, click uninstall
5. while add-ons manager is still open, hit cmd+o, navigate Finder to an xpi of a new version of the add-on (no code change, only version bump), and select it to finish install.

i'll see if i can reproduce in a clean profile.

Comment 3

[Dave Townsend [:mossop]]

Ok that makes sense, basically a problem with the hack we put in place to allow undoing uninstalls for restartless add-ons. When you uninstall but don't close the UI the add-on is actually just disabled but still installed, so installing another version is like upgrading so it retains the disabled state. Would either need another hacky solution or a proper fix of bug 612168.

Comment 4

[Dietrich Ayala (:dietrich)]

Confirmed with a new profile and hello-world add-on.

Comment 5

[Andrew Swan [:aswan]]

We're explicitly testing for the opposite of the expected behavior from the summary of this bug:

https://dxr.mozilla.org/mozilla-central/rev/ac39fba33c6daf95b2cda71e588ca18e2eb752ab/toolkit/mozapps/extensions/test/xpcshell/test_undouninstall.js#636

Comment 6

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.