Closed
Bug 733107
Opened 13 years ago
Closed 13 years ago
URL-encode values in TCBS by OS service calls
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
RESOLVED
FIXED
2.5
People
(Reporter: adrian, Assigned: espressive)
Details
(Whiteboard: [qa-])
Found that bug while trying to figure out the source of bug 729437 comment 12. It appears that values passed in the URL of TCBS by OS are not url-encoded and thus are breaking that URL.
This bug could also be used to make sure all services calls in the UI are well encoded.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → sneethling
Assignee | ||
Comment 1•13 years ago
|
||
Sent pull request :: https://github.com/mozilla/socorro/pull/421
Whiteboard: [qa-]
Comment 2•13 years ago
|
||
Commits pushed to master at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/dca1971ac778f37308da258fe1f82d1f75b6148a
ensure all parameters sent to service layer is encoded. Changed urlencode to rawurlencode fixes bug 733107
https://github.com/mozilla/socorro/commit/d7ffbf4dfb8acb9827dc08ac2289c3ab671d20df
Merge pull request #421 from ossreleasefeed/url-encode-values-byos-733107
ensure all parameters sent to service layer is encoded fixes bug 733107
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 3•13 years ago
|
||
Commit pushed to stage at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/7b66b0854e191dcf014bd4f424a873728d6d7fe3
ensure all parameters sent to service layer is encoded. Changed urlencode to rawurlencode fixes bug 733107
Reporter | ||
Updated•13 years ago
|
Target Milestone: 2.5.1 → 2.5
You need to log in
before you can comment on or make changes to this bug.
Description
•