733142 - crash [@ java.lang.RuntimeException: Unable to destroy activity {org.mozilla.fennec_aurora/org.mozilla.fennec_aurora.App}: java.lang.IllegalArgumentException: Receiver not registered: org.mozilla.gecko.GeckoNetworkManager@41951ab8: at android.app.Activity

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This bug was filed from the Socorro interface and is 
report bp-c47414b2-0dc4-4463-a93b-43eb12120303 .
============================================================= 
java.lang.RuntimeException: Unable to destroy activity {org.mozilla.fennec_aurora/org.mozilla.fennec_aurora.App}: java.lang.IllegalArgumentException: Receiver not registered: org.mozilla.gecko.GeckoNetworkManager@41951ab8
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:3108)
	at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:3126)
	at android.app.ActivityThread.access$1200(ActivityThread.java:122)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1179)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.GeckoApp$32.run(GeckoApp.java:1777)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4340)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.IllegalArgumentException: Receiver not registered: org.mozilla.gecko.GeckoNetworkManager@41951ab8
	at android.app.LoadedApk.forgetReceiverDispatcher(LoadedApk.java:628)
	at android.app.ContextImpl.unregisterReceiver(ContextImpl.java:1066)
	at android.content.ContextWrapper.unregisterReceiver(ContextWrapper.java:354)
	at org.mozilla.gecko.GeckoNetworkManager.stopListening(GeckoNetworkManager.java:178)
	at org.mozilla.gecko.GeckoNetworkManager.stop(GeckoNetworkManager.java:173)
	at org.mozilla.gecko.GeckoApp.onDestroy(GeckoApp.java:2171)
	at android.app.Activity.performDestroy(Activity.java:4629)
	at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1079)
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:3095)
	... 15 more

Comment 2

[Scoobidiver (away)]

There were no crashes in 13.0a2 and 14.0a1 up to 14.0a1/20120322031220.
There are now 36 crashes making it #1 top crasher over the last day.
The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4bdae514b9be&tochange=5c13fce74f83

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Mounir - Any chance this you can take a look at this?

Comment 4

[Mounir Lamouri (:mounir)]

I can't remember why I stop listening on onDestroy() given that it's done on onStop() too. However, Doug told me he knows what is happening but he was on a hurry so he did not tell me more.

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

I have no idea why the crash stopped because I doubt they are actually fixed. One of my guess is that I could have caused some and I stopped testing those APIs. My other guess is involving dwarfs and elves...

Comment 6

[Scoobidiver (away)]

Its reappearance in 14.0a1 might be caused by bug 737392.

(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #5)
> My other guess is involving dwarfs and elves...
I added the illustrious Copperfield to the CCs for an explanation.

Comment 7

[Mounir Lamouri (:mounir)]

Whatever the reasons of the crash could be, the only thing that could be wrong here is if we try to call stop() twice will enableNotifications() has been called. In that case, the second call will crash. GeckoNetworkManager hasn't been designed for that. Given that onDestroy() can't be called without onStop() being called, we can safely remove the call for stop() in onDestroy(). I believe.

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 610209 [details] [diff] [review]
Patch v1

Review of attachment 610209 [details] [diff] [review]:
-----------------------------------------------------------------

lets give it a go

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/82c98e0e7d71

Comment 11

[Cristian Nicolae (:xti)]

I cannot reproduce this crash either on Nightly or Aurora. Closing bug as verified fixed.

--
Firefox 15.0a1 (2012-05-02), Firefox 14.0a2 (2012-05-01)
Device: Samsung Captivate
OS: Android 2.2