Inconsistent font sizes for about:buildconfig on Fennec Native compared to desktop

VERIFIED FIXED in Firefox 18

Status

()

Firefox for Android
General
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: emorley, Assigned: capella)

Tracking

Trunk
Firefox 18
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox18 verified, blocking-fennec1.0 -)

Details

(Whiteboard: readability [MTD])

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Galaxy S2, Android 2.3.4, Fennec Native Nightly 13.0a1 2012-03-05

Perhaps similar to bug 723965 or any one of the other text size related bugs, but filing in case it's not related.

1) Go to about:buildconfig
2) Compare display of text to that shown on desktop Firefox


Expected Results:

Font sizes of heading vs subheading vs body consistent throughout the page.


Actual Results:

Under "Build platform", the "target..." text is minuscule, when compared to say the "Compiler flags..." content or the even bigger "Configure arguments" section content.
(Reporter)

Comment 1

6 years ago
Created attachment 603063 [details]
Screenshot
Blocks: 627842
blocking-fennec1.0: --- → ?
Whiteboard: [MTD] → readability [MTD]
blocking-fennec1.0: ? → -
In theory we want to treat layout tables as separate inflation units (except when the layout purpose is indendation) and semantic tables together, but I don't have a heuristic in mind for that.
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Mark:

This could be a pretty hairy bug, and is probably related to bug 707195 - the infamous "ycombinator" issue.

Not trying to dissuade you from coming up with a solution, I'm just letting you know so you don't spend a lot of time trying solutions dbaron and I have already ruled out. If you want to discuss possible solutions to the problem, though, I'm all ears. :)
(Assignee)

Comment 4

5 years ago
Created attachment 655635 [details] [diff] [review]
Patch (v1) WIP

Well I took the basic buildconfig.html and stripped out the embedded stylesheet into a new standalone version that builds everything asis (see attached plus some "debug styling" I'll strip out later).

I'm in the process of cloning that and setting a JAR.mn override for an Android version sheet to make things like nice / specific to that environment.

(I've been doing similar with bug 774500 and bug 780442 ...)

I'm unfamiliar with ycombinator and such ... is there something making this more complex than I'm aware of?
I misunderstood that mcapella was working on the about:buildconfig pages, rather than the font inflation code, to solve this bug. I withdraw my concerns. :)
(Assignee)

Comment 6

5 years ago
Created attachment 655725 [details] [diff] [review]
Patch (v2)

I thought I'd ask Margaret for feedback here, as this is similar to the other two bugs I've mentioned in comment 4.
Attachment #655725 - Flags: feedback?(margaret.leibovic)

Comment 7

5 years ago
Comment on attachment 655725 [details] [diff] [review]
Patch (v2)

Looking good to me!
Attachment #655725 - Flags: feedback?(margaret.leibovic) → feedback+

Comment 8

5 years ago
(In reply to Scott Johnson (:jwir3) from comment #5)
> I misunderstood that mcapella was working on the about:buildconfig pages,
> rather than the font inflation code, to solve this bug. I withdraw my
> concerns. :)

Scott, is there a font inflation bug here that we'd like to track? I'm all for making the easy fix to make about:buildconfig look better, but I also want to make sure closing this bug won't bury an issue we want to track.
(In reply to Margaret Leibovic [:margaret] from comment #8)
> Scott, is there a font inflation bug here that we'd like to track? I'm all
> for making the easy fix to make about:buildconfig look better, but I also
> want to make sure closing this bug won't bury an issue we want to track.

No, I don't think there is. I think the actual font inflation code that triggers this bug is actually a symptom of the larger ycombinator case. Since that's tracked in bug 707195, I think we're good.
(Assignee)

Comment 10

5 years ago
Created attachment 656513 [details] [diff] [review]
Patch (v3)

Well, after some discussion on #mobile, we found a trivially simple / cleaner solution for this particular patch ... I tested locally on my WIN, LINUX, and Galaxy-S3 and think this version might be ready :P
Attachment #655635 - Attachment is obsolete: true
Attachment #656513 - Flags: review?(bmo)
(Reporter)

Comment 11

5 years ago
Comment on attachment 656513 [details] [diff] [review]
Patch (v3)

Sorry, I don't have an Android build environment set up so can't test this.
Attachment #656513 - Flags: review?(bmo)
(Assignee)

Comment 12

5 years ago
Created attachment 656536 [details] [diff] [review]
Patch (v4)

Ok, thanks. I'll stay with margaret then since she's already helping me along.
Attachment #656513 - Attachment is obsolete: true
Attachment #656536 - Flags: review?(margaret.leibovic)

Comment 13

5 years ago
Comment on attachment 656536 [details] [diff] [review]
Patch (v4)

Nice, I like the simplicity of this (and it sounds like a good strategy for the other toolkit about: pages that look bad on mobile).

I'm fine with us landing this patch as is because it's a big improvement, but there's still a little bit of weirdness, most noticeably the fact that there's extra padding on the left side of the body. This is because we're pulling in styles from about.css:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/about.css

I'm not sure why we have that -moz-padding-start rule on the body in there, but changing that would require checking out all the files that depend on about.css. That could be tedious, but potentially a good cleanup. However, we could also just override that style in a buildconfig.css file, like you added in your previous patch.
Attachment #656536 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 14

5 years ago
Push to TRY:
https://tbpl.mozilla.org/?tree=Try&rev=d7de9bacbd55
(Assignee)

Comment 15

5 years ago
On to inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=56947ab51eb9
https://hg.mozilla.org/mozilla-central/rev/56947ab51eb9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
The font issue was fixed for about:buildconfig on the latest Nightly. Closing bug as verified fixed on:

Firefox 18.0a1 (2012-09-24)
Device: Galaxy Note
OS: Android 4.0.4
Status: RESOLVED → VERIFIED
status-firefox18: --- → verified
You need to log in before you can comment on or make changes to this bug.