733175 - Don't look for MPL2 headers in generated test assets

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Line over here https://github.com/mozilla/addon-sdk/pull/355/files#L1R57 triggered bug 733173 which I guess did not properly cleaned up it's generated docs that caused MPL2 Header tests to fail:

The following files are missing an MPL2 header:
python-lib/cuddlefish/tests/static-files/sdk-docs/doc/static-files/js/jquery.js
python-lib/cuddlefish/tests/static-files/sdk-docs/doc/static-files/syntaxhighlighter/scripts/shBrushCss.js
python-lib/cuddlefish/tests/static-files/sdk-docs/doc/static-files/syntaxhighlighter/scripts/shBrushJScript.js
python-lib/cuddlefish/tests/static-files/sdk-docs/doc/static-files/syntaxhighlighter/scripts/shBrushXml.js
python-lib/cuddlefish/tests/static-files/sdk-docs/doc/static-files/syntaxhighlighter/scripts/shCore.js

Not sure if that's issue on the one test or another but we should fix the issues to make sure we don't see falsy failures.

Comment 1

[Brian Warner [:warner :bwarner]]

Attachment: don't scan generated sdk-docs/ directory for MPL2 license files

In general, tests should be putting tempfiles in tempdirs and not scattered throughout the source tree. But here is a quick fix to avoid scanning the specific directory created by test_generate.py.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 603070 [details] [diff] [review]
don't scan generated sdk-docs/ directory for MPL2 license files

Review of attachment 603070 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a3594387d40716f9647eb3c56f849c67caa73165
Bug 733175: MPL2-scanner should ignore generated docs files. r=@gozala