Closed
Bug 733182
Opened 14 years ago
Closed 14 years ago
Add method to get the total GCheap allocated code memory
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rulohani, Unassigned)
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
pnkfelix
:
review+
|
Details | Diff | Splinter Review |
GetTotalCodeSize returns gcheapCodeMemory + externalCodeMemory. Add another API which just returns gcheapCodeMemory for clarity of purpose where intent is only to get gcheap allocated memory.
Attachment #603073 -
Flags: review?(fklockii)
|
||
Updated•14 years ago
|
Attachment #603073 -
Attachment is patch: true
|
|
||
Comment 1•14 years ago
|
||
Comment on attachment 603073 [details] [diff] [review]
Patch
Review of attachment 603073 [details] [diff] [review]:
-----------------------------------------------------------------
::: MMgc/GCHeap.h
@@ +554,5 @@
>
> + /**
> + * @return the amount of code memory currently allocated by GCHeap. GCHeap does not
> + * have a notion of "free" and "used" code memory.
> + */
I would add @see lines connecting together GetTotalCodeSize, SignalCodeMemoryAllocated, and SignalCodeMemoryDeallocated, since these all seem to be related to maintaining the statistics here.
Attachment #603073 -
Flags: review?(fklockii) → review+
|
|
||
Comment 2•14 years ago
|
||
changeset: 7254:16009ad7635c
user: Ruchi Lohani<rulohani@adobe.com>
summary: Bug 733182 - Add method to get the total GCheap allocated code memory (r=fklockii)
http://hg.mozilla.org/tamarin-redux/rev/16009ad7635c
|
|
Reporter | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•