Maple: Remove some Java logging

RESOLVED FIXED

Status

()

Firefox for Android
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 603076 [details] [diff] [review]
patch

This logging is hurting performance and is getting in the way of profiling. If we care about keeping some of this should move it to a system where we can toggle it.

Asking pwalton for review since he added/used most of these.
Attachment #603076 - Flags: review?(pwalton)
Comment on attachment 603076 [details] [diff] [review]
patch

Review of attachment 603076 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, all of the logging was really annoying.
Attachment #603076 - Flags: review?(pwalton) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 603106 [details] [diff] [review]
Remove widget logging

I forgot some logging in widget
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #603106 - Flags: review?(pwalton)
Comment on attachment 603106 [details] [diff] [review]
Remove widget logging

Review of attachment 603106 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #603106 - Flags: review?(pwalton) → review+
OS: Mac OS X → Android
Hardware: x86 → ARM
(Assignee)

Comment 4

6 years ago
Landed. FYI attachment 603106 [details] [diff] [review] was modified before landing and pcwalton give me a IRC r+ for the amended changes.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.