Closed Bug 73326 Opened 25 years ago Closed 25 years ago

"Wrap text to left" and "Wrap text to right" are opposite of correct value in Image dialog

Categories

(Core :: DOM: Editor, defect)

x86
Windows NT
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: cmanske, Assigned: cmanske)

Details

(Keywords: regression)

Attachments

(1 file)

The "Align Text to Image" menu in the Image properties dialog describes the wraping of the *text*, not the image, which is clearer for the user. But the HTML attribute is on the <img> tag and is the opposite sense, describing the location of image relative to the text. Thus the "value" should be "right" for the item "Wrap to the left" and value should be "left" for "Wrap to the right". Someone must have thought this was an error and changed either the XUL or JS so that it is now wrong. The NS6.0 release was correct.
Fix is ready.
Status: NEW → ASSIGNED
Keywords: regression
Whiteboard: FIX IN HAND need r=, sr=
Target Milestone: --- → mozilla0.9
Attached patch Simple fix.Splinter Review
r=blake
Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND
checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND
verified in 4/6 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: