733275 - adding an interface removes sticky interface routes

Status: RESOLVED FIXED

(Infrastructure & Operations :: Infrastructure: Other, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

If you add a new interface to a system with network::vlan, the network subsystem gets restarted, and the ip route tables get deleted.

This is easy to forget and accidentally un-stick all of the interfaces on e.g., an admin host.

Currently, puppet-{iproute,iprule} get run via rc.local.  Is there a network initscript they could be attached to, instead?

Comment 1

[Brian Hourigan [:digi]]

:dustin

I have an idea for a fix, is there a particular host that this can be tested on?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I don't have one, but certainly we could spin up a VM.  There are a few VMs on KVM right now that are just there to generate load - we could use one of those.  Find me in IRC when you want to try.

Comment 3

[Brian Hourigan [:digi]]

I saw this scroll by earlier on irc, the standard RHEL6 /etc/sysconfig/network-scripts/ifup-post script supports local network up/down hooks.

/sbin/ifup-local $DEVICE
/sbin/ifdown-local $DEVICE

It gets executed automatically if it exists and is +x

Comment 4

[Brian Hourigan [:digi]]

Deployed fix, tested on admin1b.private.pek1.

[[e-mail]1 ~]# ip route show table 70
10.24.70.0/24 dev bond0.70  scope link 
default via 10.24.70.1 dev bond0.70 
[[e-mail]1 ~]# service network restart
Shutting down interface bond0.70:                          [  OK  ]
Shutting down interface bond0.74:                          [  OK  ]
Shutting down interface bond0.75:                          [  OK  ]
Shutting down interface bond0.77:                          [  OK  ]
Shutting down interface bond0.8:                           [  OK  ]
Shutting down interface bond0.80:                          [  OK  ]
Shutting down interface bond0:                             [  OK  ]
Shutting down loopback interface:                          [  OK  ]
Bringing up loopback interface:                            [  OK  ]
Bringing up interface bond0:                               [  OK  ]
Bringing up interface bond0.70:                            [  OK  ]
Bringing up interface bond0.74:                            [  OK  ]
Bringing up interface bond0.75:                            [  OK  ]
Bringing up interface bond0.77:                            [  OK  ]
Bringing up interface bond0.8:                             [  OK  ]
Bringing up interface bond0.80:                            [  OK  ]
[[e-mail]1 ~]# ip route show table 70
10.24.70.0/24 dev bond0.70  scope link 
default via 10.24.70.1 dev bond0.70

Comment 5

[Brian Hourigan [:digi]]

Just wanted to mention - this fix works on both RHEL5 and RHEL6