733299 - Page Info > Media > Save As should save the (pinned) cache entry rather than revalidating/redownloading

Status: RESOLVED INCOMPLETE

(Firefox :: Page Info Window, defect)

Description

[Jesse Ruderman]

On http://www.youtube.com/watch?v=FG0fTKAqZ5g, saving the video from Page Info usually redownloads it, even if it has already loaded completely in the youtube interface.

Comment 1

[Philip Chee]

http://hg.mozilla.org/mozilla-central/annotate/7d0d1108a14e/browser/base/content/pageinfo/pageInfo.js#l822

>      saveURL(url, null, "SaveImageTitle", false, false, makeURI(item.baseURI));
The fourth parameter is aShouldBypassCache and it's false so we use:
Components.interfaces.nsIWebBrowserPersist.PERSIST_FLAGS_FROM_CACHE

So IIRC the Flash plugin uses it's own storage and not the browser cache.

Comment 2

[Jesse Ruderman]

I'm not using the Flash plugin.

Comment 3

[Philip Chee]

According to the media tab in page info:
Address; http://s.ytimg.com/yt/swfbin/watch_as3-vflVEINBz.swf
Type: application/x-shockwave-flash
Cache Source: Disk cache
Size: 244.54 KB (250,413 bytes)

Save As WFM: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120317 Firefox/14.0a1 SeaMonkey/2.11a1

Comment 4

[Jesse Ruderman]

It's a webm video for me, fwiw.

Comment 5

[Philip Chee]

I fired up Minefield/Nightly and I still got a flash video. Cleared private data. Still got a flash video.
OK. Got it. Jesse forgot to mention in the STR that you need to go and join the youtube html5 beta program before you can see html5 video.
So
Location: http://o-o.preferred.tm-jhb1.v21.lscache6.c.youtube.com/videoplayback?sparams=cp%2Cid%2Cip%2Cipbits%2Citag%2Cratebypass%2Csource%2Cexpire&itag=43&ip=175.0.0.0&signature=29AF1840BAB1C247B0A82A6E195F10C2283C6653.49D22117D49682F9A2309296DE4606BEE11386BC&sver=3&ratebypass=yes&source=youtube&expire=1332007278&key=yt1&ipbits=8&cp=U0hSR1BLVV9MUkNOMl9IRVlDOllKMERpdURWSWJh&id=146d1f4ca02a6798
Type: video/webm
Size: 12,210.23 KB (12,503,280 bytes)

Save As is instantaneous. Only quirk is that the resulting file is videoplayback.htm :P

So still WFM.

Comment 6

[George Butel]

I was downloading some video course lectures from The Teaching Company; these days, you have to "save as" and it commences the download in a new tab, as m4v files. For years, I've used mainly either FF or Chrome, depending on which one I'm mad at, and, yesterday, I became annoyed enough at FF's "modern" interface that I closed FF, told it to cancel the ongoing downloads, then downloaded the files in Chrome. They're about half a gb each. When I reopened FF later, it re-commenced the downloads, annihilating two completely downloaded lectures, more than a gb total. I thought at first it was because I had FF set to open whatever tabs had been open when I closed it, so I changed that to make it just a certain page, but when I reopened FF again, it started the downloads yet again, wiping out the re-downloads in progress. Then I realized that the only way to control it is from the download drop-down menu, where you have to tell FF to stop, or else, in true Dracula fashion, it will apparently keep trying the downloads forever. You need a pop-up dialog box to ask the user about any downloads in progress, i.e., not whether to cancel them, which is what it does, but if the user wants them to be retried when FF reopens, or, preferably, change this default behavior. I have AT&T's molasses brand dsl, and it takes several hours to dl a gb, and I cannot stand having to redo such downloads.

Comment 7

[George Butel]

(In reply to George Butel from comment #6)
> I was downloading some video course lectures from The Teaching Company;
> these days, you have to "save as" and it commences the download in a new
> tab, as m4v files. For years, I've used mainly either FF or Chrome,
> depending on which one I'm mad at, and, yesterday, I became annoyed enough
> at FF's "modern" interface that I closed FF, told it to cancel the ongoing
> downloads, then downloaded the files in Chrome. They're about half a gb
> each. When I reopened FF later, it re-commenced the downloads, annihilating
> two completely downloaded lectures, more than a gb total. I thought at first
> it was because I had FF set to open whatever tabs had been open when I
> closed it, so I changed that to make it just a certain page, but when I
> reopened FF again, it started the downloads yet again, wiping out the
> re-downloads in progress. Then I realized that the only way to control it is
> from the download drop-down menu, where you have to tell FF to stop, or
> else, in true Dracula fashion, it will apparently keep trying the downloads
> forever. You need a pop-up dialog box to ask the user about any downloads in
> progress, i.e., not whether to cancel them, which is what it does, but if
> the user wants them to be retried when FF reopens, or, preferably, change
> this default behavior. I have AT&T's molasses brand dsl, and it takes
> several hours to dl a gb, and I cannot stand having to redo such downloads.

I forgot to question this: I'm flabbergasted as to how, instead of appending a (1) to the end of a file when it sees a pre-existing file of the same name, the downloader deleted the original and started anew. I've never seen that before.

Comment 8

[Jesse Ruderman]

George, please file a new bug on that (and comment with the new bug number). Your problem sounds unrelated to this bug, which is about Page Info and cache behavior.

Comment 9

[:Gijs (he/him)]

Florian, did this get fixed by your patch in bug 415225 as well?

Comment 10

[Florian Quèze [:florian]]

(In reply to :Gijs (he/him) from comment #9)

Florian, did this get fixed by your patch in bug 415225 as well?

I don't know, I can't try to reproduce following the description in comment 0 as youtube has most likely dramatically changed in 12 years, so I'll close this bug.