733328 - Disable reviews for add-ons without at least one author who receives review mail

Status: RESOLVED INVALID

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Kris Maglione [:kmag]]

It is currently possible, as far as I can tell, for an add-on to be nominated for review when none of its authors have opted to receive review mail. Add-ons should be removed from the queue, and the author warned when attempting to nominate, if no authors have selected "[notify me when] my add-on is reviewed by an editor".

In Remora, this caused serious problems when hidden developers did not receive review mail and add-ons had no visible developer. I can't say for certain that it's causing issues now, as I don't have access to user setting pages, but we have fairly frequent problems with users ignoring our review caveats, and I suspect that at least some of the time it's because they aren't receiving their review mail.

Comment 1

[Wil Clouser [:clouserw]]

Where is the "[notify me when] my add-on is reviewed by an editor" setting?  Why don't we just disable that?

Comment 2

[Kris Maglione [:kmag]]

https://addons.mozilla.org/users/edit#id_notifications_11

I'm all for disabling it, if you think that's acceptable.

Comment 3

[Wil Clouser [:clouserw]]

That checkbox is greyed out (and checked) on my profile.

Comment 4

[Kris Maglione [:kmag]]

(In reply to Wil Clouser [:clouserw] from comment #3)
> That checkbox is greyed out (and checked) on my profile.

Ah. This is true. I can't even tell except at steep viewing angles on my LCD. It would help if the label were grayed out as well, if not for the fact that all of the labels are already gray.