Closed Bug 73336 Opened 23 years ago Closed 22 years ago

Put recursion defense into trees

Categories

(SeaMonkey :: Bookmarks & History, defect)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED WONTFIX
mozilla1.1alpha

People

(Reporter: mikepinkerton, Assigned: hyatt)

References

Details

(Whiteboard: wontfix? (what tree. I don't see no tree).)

Attachments

(1 file)

- launch mozilla (3/23/01 build, modern skin)
- go to a webpage
- "Bookmarks:Add Bookmark"

app will freeze and a look at the stack shows we're flushing pending reflows in
an infinite recursion. must force-quit app.
Can anyone else reproduce this? Works for me using my mozilla debug build from
this morning (03/26/01).
i can repro with 3/26 stuffit archive. 
doesn't happen in a new profile, but that doesn't mean it isn't a problem.
Cannot be reproduced with the smoketest. I also tried and don't see the problem 
with 03/26 build.
reducing severity from blocker to critical until Pink figures out what's wrong 
with his system.
Severity: blocker → critical
attaching my bookmark list. it happens for me on _two_ separate machines, and 
about the only thing they might have in common are various bookmarks.
--> pchen
Assignee: ben → pchen
Keywords: smoketestnsdogfood
Claudius, any luck trying to repro this?
i found that if i closed up some folders in the 'manage bookmarks' window, the 
crash went away. That means this bug is dependent on how complicated the tree 
widget in the dialog is, and it is freaking out in certain cases (since bookmarks 
remembers which folders are open/closed).

This will bite users at random, so please don't mark this WFM. Perhaps moving to 
an outliner will solve it once and for all. cc'ing hyatt.
I have the 350k bookmarks file from hell that is used for performance testing. It has many,
many folders nested as much as five levels deep. It is also fully expanded.
I tried to add a bookmark to this file and in the add bookmark dialog that comes up I tried
to scroll the bookmarks view. The instant i clicked the arrow the app hung. A minute or so
later I got an exception in the BowelsOfTheMemoryMgr. Is this like what you were seeing pink?
YES! woohoo!!!!!
oh, wait, i never get the add bookmarks dialog....it crashes before that.

if you break with macsbug while it's hung, you should see a very very long stack 
that is basically two reflow routines alternating all the way down.
as it turns out mike pinkerton, nor his systems, is not crazy. Although i am fortunate enough
to see the dialog it just delays the inevitable. After I click the scroll arrow(and hang) and look
at the stack it seems I'm stuck looping between:

PresShell::ProcessReflowCommands(int)+00230
PresShell::HandlePostedReflowCallbacks()+000A8
PresShell::FlushPendingNotifications()+0003C

forever and ever until I give up or crash

ummm, so to be clear this is easily reproducible and horribly bad. The only reason this
makes it through smoketests is that a new profile is always used and the default bookmarks
file is tiny.
*** Bug 73952 has been marked as a duplicate of this bug. ***
Transferring smoketest blocker status from bug 73952
Severity: critical → blocker
Keywords: smoketest
I think this is really a dup of bug 72016. Giving to evaughan
Assignee: pchen → evaughan
Looking at it.
Hyatt has an idea
Assignee: evaughan → hyatt
we think changing from <grid> to <box> in this instance fixed the 
immediate problem. However, this bug has been seen elsewhere (news 
subscribe dialog, for instance) so it is still a problem.

downgrading to critical, keeping it open. If the xul change doesn't fix it, 
please re-raise to blocker.
Severity: blocker → critical
I've seen the bug today on the 0.8.1 release win32 build. It seems it's older
thaan 3/26 and therefore could be really closely related to bug 72016
Status: NEW → ASSIGNED
Summary: Adding bookmarks goes into infinite recursion → Put recursion defense into trees
Target Milestone: --- → mozilla1.1
that's great news. that means maybe we have a prayer of getting it debugged on a 
platform others care about.
OS: Mac System 9.x → All
Hardware: Macintosh → All
*** Bug 74108 has been marked as a duplicate of this bug. ***
David, is it possible there's a simple fix for this?  I'm reluctant to dogfood-
this since the only workaround is to hork your bookmarks all around to avoid
hitting this problem with them.  I'm also reluctant to dogfood+ this because
only one person has had the problem in daily use...
three people: me, claudius, and the smoketester
I've had this problem on 0.8.1 (during regular use, but with a large bookmark
file) and discovered that dragging the clip from the url bar doesn't trigger the
crash. Pure luck, or is there a reason behind this?
Blocks: 104166
Adding nsbeta1 keyword to all regressions so they *get some love* and attention.
Keywords: nsbeta1
Given that we don't use a tree in bookmarks anymore, is this hungering for 
some WONTFIX form of love?
Whiteboard: wontfix? (what tree. I don't see no tree).
removing keywords, resolving as wontfix
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → WONTFIX
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: