733450 - 'zoom out' link does nothing and is listed even when the user is completely zoomed out

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://addons-dev.allizom.org/z/en-US/statistics/addons_in_use/?last=30
2. Click on the 'zoom out' link


expected behavior:
'zoom out' link is available only when the user has zoomed in. Otherwise we list the 'zoom in' link.


observed behavior:
'zoom out' is listed even when the user is completely zoomed out and clicking on it does nothing.

Comment 1

[Potch [:potch]]

what if I change it to "reset zoom", which is actually what it does? would it make more sense then?

Comment 2

[krupa raj[:krupa]]

(In reply to Potch [:potch] from comment #1)
> what if I change it to "reset zoom", which is actually what it does? would
> it make more sense then?

Yes. Will the link be available when the user hasn't changed the zoom settings in any way?

Comment 3

[Davor Spasovski [:spasovski]]

done: https://github.com/mozilla/zamboni/commit/53cca9d

Comment 4

[krupa raj[:krupa]]

verified fixed at https://addons-dev.allizom.org/z/en-US/statistics/addons_in_use/?last=30