73349 - internet shortcuts are not created properly

Status: VERIFIED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[sean echevarria]

Ever since this change to navigatorDD.js:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=navigatorDD.js&root=/cvsroot&subdir=mozilla/xpfe/browser/resources/content&command=DIFF_FRAMESET&rev1=1.52&rev2=1.53

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/xpfe/browser/resources/content/navigatorDD.js
internet shortcuts have not been created properly.
Shortcuts are created with a the first word missing from the title.  That word
appears in the shortcut file on the line after the url line.

Will attach possible fix.

Comment 1

[sean echevarria]

Attachment: patch - possible fix for inet shortcut creation bug

Comment 2

[sean echevarria]

I believe this also prevents shortcuts from being created if the title of the
document does not contain a space.

Will test patch on Monday.

Comment 3

[sean echevarria]

Attachment: update patch

Comment 4

[sean echevarria]

Tested patch on Win2k with fresh pull from the tip.
Peter, can you please review?

Comment 5

[Peter Trudelle]

not my area.  ->xpapps.

Comment 6

[sean echevarria]

Paul, can you please either review the attached patch or let me know who should 
review it?

Comment 7

[sean echevarria]

reassigning to self.
chnging component to xpapps:dnd
cc'ing Mike since he's had his hands in nsDataObj.cpp.

Mike, can you please review the attached patch?

Comment 8

[Mike Pinkerton (not reading bugmail)]

why are we truncating the url at |lineIndex + 1|? wouldn't that then include the 
linefeed in the url?

+      if ( lineIndex > 0 ) {
+        outURL.Truncate ( lineIndex+1 );

Comment 9

[sean echevarria]

Yes, it does include the newline but it's written out as a linebreak, not as 
part of the url.  I opened up an internet shortcut created by IE and it had a 
linebreak after the last line, so I explicitly made that change.

Comment 10

[sean echevarria]

And I think I see your point - the linebreak shouldn't come from the url but be 
written explicitly if we wanted it.

Comment 11

[Mike Pinkerton (not reading bugmail)]

correct ;)

i'd prefer to have it explicitly be put into the file, thus better documenting 
the file format and not relying on the magical, mystical \n coming from the URL.

Comment 12

[sean echevarria]

new patch in the works...

Comment 13

[sean echevarria]

Attachment: new patch - with explicit file format string

Comment 14

[Mike Pinkerton (not reading bugmail)]

looks good, r=pink.

Comment 15

[sean echevarria]

Chris Blizzard wrote (and copied to [e-mail]):
Can't you use something like PR_sprintf() instead of just sprintf()? Other than 
that looks good. sr=blizzard

--Chris

Comment 16

[sean echevarria]

Attachment: patch per Blizzard comments

Comment 17

[sean echevarria]

checked in -> Fixed

Checking in nsDataObj.cpp;
/cvsroot/mozilla/widget/src/windows/nsDataObj.cpp,v  <--  nsDataObj.cpp
new revision: 1.38; previous revision: 1.37
done

Comment 18

[Terri Preston]

Verified fixed w2k build 2001081003