Closed
Bug 733504
Opened 12 years ago
Closed 12 years ago
More workarounds llvm.org/pr12127
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 file)
3.08 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
For some reason on centos5 64 we are more sensitive to stack usage than on fedora16 64 where I tested 731503. This patch adds MOZ_NEVER_INLINE to the next 4 largest functions in stack usage. I have not tested with lest, but with these we avoid hitting too much recursion on try: https://tbpl.mozilla.org/?tree=Try&rev=ecb3bc140330 (the remaining error is unrelated (centos linker corrupting eh_frame)).
Attachment #603415 -
Flags: review?(dvander)
Updated•12 years ago
|
Attachment #603415 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 1•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1ee8b185cbdb
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1ee8b185cbdb Please try to remember to set assignee and target milestone when landing, if possible :-)
Assignee: general → respindola
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Assignee | ||
Comment 3•12 years ago
|
||
I normally set Assignee when I started working on a bug to avoid overlap with someone else, but I already had a patch when I opened this one, so it should have been clear. That is not how we use Assignee? What do we use Milestone for?
You need to log in
before you can comment on or make changes to this bug.
Description
•